Revert Jewel Update #947
Merged
Revert Jewel Update #947
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZacSweers
approved these changes
Sep 4, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Sep 5, 2024
This is a continuation of #927, but because of the Jewel update in #937, I ended up running into some hiccups with transitioning the project and migrating to a different version of intellij gradle platform plugin. We reverted it back in #947 and this PR reflects the changes that are compatible with the old Jewel version (which is back on main). I have included the functionality for user input, where send button clears text, enter clears text, and shift + enter adds new lines. Users can also add multiple lines. I also added a function where the send button is faded and unselectable until there is text input. In future PRs, I will add the chat conversation as well, and this is just a start. https://github.com/user-attachments/assets/94971a43-476e-4d67-924c-e012c633bc3c <!-- ⬆ Put your description above this! ⬆ Please be descriptive and detailed. Please read our [Contributing Guidelines](https://github.com/tinyspeck/slack-gradle-plugin/blob/main/.github/CONTRIBUTING.md) and [Code of Conduct](https://slackhq.github.io/code-of-conduct). Don't worry about deleting this, it's not visible in the PR! -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts PR #937 as it was causing issues with the Skate plugin. It needs to be upgraded in the future along with migrating to IntelliJ Platform Gradle Plugin 2.x.