Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

slack-15.0: VStreams fix backports/patches, pt. 2 #380

Merged
merged 7 commits into from
May 29, 2024

Conversation

timvaillancourt
Copy link
Member

@timvaillancourt timvaillancourt commented May 29, 2024

Description

Slack patches:

  1. apply patch 12623 #132
  2. VStreams NOT_FOUND Error Retries and Omits Tablet #154 (not upstreamed, @makinje16 is that planned?)

Backports:

  1. VReplication: Ensure ROW events are sent within a transaction vitessio/vitess#13547
  2. Update tabletpicker to support cell pref and tablet order options vitessio/vitess#12282
  3. allow tablet picker to exclude specified tablets from its candidate list vitessio/vitess#14224

Related Issue(s)

Checklist

  • "Backport to:" labels have been added if this change should be back-ported
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on the CI
  • Documentation was added or is not required

Deployment Notes

pbibra and others added 3 commits May 29, 2024 02:11
* apply patch 12623

Signed-off-by: Priya Bibra <pbibra@slack-corp.com>

* fix unit test

Signed-off-by: Priya Bibra <pbibra@slack-corp.com>

* revert regex

Signed-off-by: Priya Bibra <pbibra@slack-corp.com>

* update regex

Signed-off-by: Priya Bibra <pbibra@slack-corp.com>

---------

Signed-off-by: Priya Bibra <pbibra@slack-corp.com>
…tessio#12282)

* update tabletpicker to support cell pref and tablet order options

Signed-off-by: Priya Bibra <pbibra@slack-corp.com>

* add tablet picker options in vstream flags

Signed-off-by: Priya Bibra <pbibra@slack-corp.com>

* add tablet picker tests

Signed-off-by: Priya Bibra <pbibra@slack-corp.com>

* add summary docs

Signed-off-by: Priya Bibra <pbibra@slack-corp.com>

* update proto

Signed-off-by: Priya Bibra <pbibra@slack-corp.com>
Signed-off-by: 'Priya Bibra' <pbibra@slack-corp.com>

* fix vreplication test

Signed-off-by: Priya Bibra <pbibra@slack-corp.com>
Signed-off-by: 'Priya Bibra' <pbibra@slack-corp.com>

* fix doc typos, add function comments, update error handling

Signed-off-by: Priya Bibra <pbibra@slack-corp.com>
Signed-off-by: 'Priya Bibra' <pbibra@slack-corp.com>

* fix tests and comments

Signed-off-by: Priya Bibra <pbibra@slack-corp.com>

* fix local cell ref

Signed-off-by: Priya Bibra <pbibra@slack-corp.com>

* update proto

Signed-off-by: Priya Bibra <pbibra@slack-corp.com>

* add log line to debug test

Signed-off-by: Priya Bibra <pbibra@slack-corp.com>

* add cell to vre test def

Signed-off-by: Priya Bibra <pbibra@slack-corp.com>

* define vrepl engine for controller tests

Signed-off-by: Priya Bibra <pbibra@slack-corp.com>
Signed-off-by: 'Priya Bibra' <pbibra@slack-corp.com>

---------

Signed-off-by: Priya Bibra <pbibra@slack-corp.com>
Signed-off-by: pbibra <pbibra@slack-corp.com>
Signed-off-by: 'Priya Bibra' <pbibra@slack-corp.com>
Copy link

Thanks for the contribution! Before we can merge this, we need @mattlord to sign the Salesforce Inc. Contributor License Agreement.

@github-actions github-actions bot added this to the v15.0.5 milestone May 29, 2024
…ist (vitessio#14224)

Signed-off-by: Priya Bibra <pbibra@slack-corp.com>
timvaillancourt and others added 3 commits May 29, 2024 03:06
Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
@timvaillancourt timvaillancourt marked this pull request as ready for review May 29, 2024 02:06
@timvaillancourt timvaillancourt requested a review from a team as a code owner May 29, 2024 02:06
@timvaillancourt timvaillancourt merged commit dce7107 into slack-15.0 May 29, 2024
193 of 194 checks passed
@timvaillancourt timvaillancourt deleted the bp-vstreams-fixes-pt2-slack-15.0 branch May 29, 2024 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants