-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: Plot Config Import/Export #32
Conversation
f868d2b
to
9ac1d30
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great. Only noted for more docstrings for one of the classes.
Docstrings is a common issue of mine, apologies. Check again? |
21419e2
to
8992ea3
Compare
8992ea3
to
ce4dae5
Compare
Conflicts: archive_viewer/archive_viewer.py
Dude, I hate merge conflicts so much |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great. I just had one style suggestion for how I order my imports block
Builds on #27