Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Plot Config Import/Export #32

Merged
merged 7 commits into from
Sep 4, 2024
Merged

Conversation

aksharsarvesh
Copy link
Collaborator

@aksharsarvesh aksharsarvesh commented Aug 13, 2024

Builds on #27

Copy link
Collaborator

@YektaY YektaY left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great. Only noted for more docstrings for one of the classes.

archive_viewer/mixins/plot_config.py Show resolved Hide resolved
@aksharsarvesh
Copy link
Collaborator Author

Docstrings is a common issue of mine, apologies. Check again?

@aksharsarvesh aksharsarvesh force-pushed the exportPlot branch 2 times, most recently from 21419e2 to 8992ea3 Compare August 29, 2024 18:11
Conflicts:
	archive_viewer/archive_viewer.py
@aksharsarvesh
Copy link
Collaborator Author

Dude, I hate merge conflicts so much

Copy link
Collaborator

@zdomke zdomke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great. I just had one style suggestion for how I order my imports block

archive_viewer/mixins/plot_config.py Outdated Show resolved Hide resolved
@YektaY YektaY merged commit a0bb9de into slaclab:main Sep 4, 2024
0 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants