ENH: Plot Config #27
Merged
ENH: Plot Config #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aksharsarvesh
force-pushed
the
PlotConfig
branch
from
625f466
to
cf19121
Compare
zdomke
reviewed
Jul 31, 2024
aksharsarvesh
force-pushed
the
PlotConfig
branch
from
510e51d
to
db0a1b9
Compare
YektaY
approved these changes
Aug 28, 2024
| from pyqtgraph import ViewBox | ||
|
|
||
|
|
||
| class PlotConfigMixin: |
There was a problem hiding this comment.
Style: Can you add docstrings to all the methods in this class?
for reference on the docstring format we are using:
https://numpydoc.readthedocs.io/en/latest/format.html
|
Added docstrings and fixed merge conflicts. This PlotConfig was self contained to this repo so it should be safe to merge whenever you want it |
|
apologies, looks like a new merge conflict appeared after I merged your other PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added functionality to the Plot tab such that a user can set up the viewer however they like. The option to add more functions in the future remains, and it would not be that difficult to do so.