HTML conversion fixes and small improvements #1239
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes some changes to the HTML-to-spanned-text converter that fix some formatting inconsistencies between the app and the GitHub UI:
<pre>
tags are now treated as code blocks (as the GitHub UI does) instead of being rendered as monospaced pre-formatted blocks without a background.This change also allows to simplify the handling of highlighted code blocks: they don't need to be handled in a special way since they are just
pre
s wrapped in adiv
.<tt>
tags are now treated in the same way as<code>
tags<samp>
tags are now rendered as simple monospaced inline text (they were previously ignored)<ol>s
and ordered lists which have newlines between each item are now displayed correctly.This was done by implementing a custom
LeadingMarginSpan
to render the number (like1.
) before the content of the list item. The implementation was inspired by this SO answer and by the BulletSpan implementation.