Return previous error and exception handlers #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previous error and exception handlers are thrown away, which conflicts with the intent of `ErrorHandler::install()`.
Codecov Report
@@ Coverage Diff @@
## master #2 +/- ##
=========================================
Coverage 99.71% 99.71%
Complexity 303 303
=========================================
Files 23 23
Lines 700 700
=========================================
Hits 698 698
Misses 2 2Continue to review full report at Codecov.
|
|
@shadowhand Nice catch, thank you! Merged. |
|
@victorstanciu please make a bugfix release, I can't use SlashTrace without this due to Monolog ErrorHandler logging being lost. |
|
Never mind, you already did! 🥇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous error and exception handlers are thrown away, which conflicts with the intent of
ErrorHandler::install().