fix bc style breaks from rouge 3.x #1226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Matthew Peveler <matt.peveler@gmail.com>
|
This should have gone in 2.5, but I put it into |
|
People have been asking (#744) for the JSON highlighting to be improved (the behaviour immediately pre-2.5 was a regression itself from earlier rouge behaviour), should we take this opportunity to style the keys differently? I'm not familiar with rouge at all, but just for clarity, people can still swap out the syntax highlighting theme for any of the bundled ones and things will still work ok without additional changes? |
|
Wow, huh, no idea this change would be desired. I would agree with having a different color, though not sure what the best color/style for this would be. Upstream has them be white.
Yes, they could use one defined in Rouge, or make their own similar to what I'm doing here. I can add a section to the readme on how to do this. |
Yep, I'm not sure what the old Slate default actually was, the screenshots on #744 and rouge-ruby/rouge#675 have different colours and the screenshot in the README must have also been updated. By using a monokai-sublime theme in highlight.js I think that |
|
some different options: white ( orange ( bright pink ( I'm good with changing it to bright pink. |
Me too. |
Signed-off-by: Matthew Peveler <matt.peveler@gmail.com>
|
Alright, updated the wiki doc on customizing slate's theme as well to include description of modifying the code highlighting styling: https://github.com/slatedocs/slate/wiki/Custom-Slate-Themes |
MasterOdin
added a commit
that referenced
this pull request
May 19, 2020
* fix bc style breaks from rouge 3.x Signed-off-by: Matthew Peveler <matt.peveler@gmail.com> * use bright_pink for Name::Label Signed-off-by: Matthew Peveler <matt.peveler@gmail.com>
patrickryan79
referenced
this pull request
in patrickryan79/slate
Oct 15, 2020
* Add editorconfig (#891) * Update nav-text to update toc text too, fixes #885 * Add optional NestingUniqueHeadCounter header ID generator * Move nesting generator to separate class * Major bug fix, code simplification * Get rid of global value, use class variable instead. * fixed Markdown code formatting using backticks inside HTML code block in _errors.md (#905) * Parameterize ToC titles, remove html tags from slug (thx seweil), fixes #904 * Fix #837 Chinese, Russian headers, thx finalnova * Fix bug where wrapping the logo in an <a> tag would brake it * remove unneccessary offensive language :hug: (#910) * Update README.md (#919) Fixed typo * Add notes about spectrum * Add changelog for 2.2 * Allow strikethrough with two tildes in markdown, fixes #929 * Upgrade to latest jQuery (3.2.1) (#939) * Fix broken list, replaces #918 * Increase memory of Vagrant, fixes #601 hopefully * Cleans HTML before setting document.title (#946) Fixes slatedocs#945 * Update .editorconfig to allow trailing whitespace in .md files (#947) * Rename OS X as macOS (#950) * Rename OS X to macOS in deploy.sh comment (#951) * Fixes #909, reverts "don't pushState", using replaceState instead (#949) Partially reverts 95f924f. * Remove IBM from "Companies Using Slate" (#964) * Remove outdated Fidor Bank example (#963) * Factor nav-padding into search input width (#967) Hardcoded value of 30px no longer works when navigation padding is changed. This is now calculated dynamically. * Make quotes consistent in Gemfile (#983) * Remove invalid links (#979) * [Security] Bump nokogiri from 1.6.8.1 to 1.8.2 (#980) * Adding js to language bindings in sample intro (#1000) * Fix ToC issues, fix #995 * Cut version 2.3 * Update sprockets, cut version 2.3.1 * Update issue template to direct users to changelog instead of git commits * [Security] Bump nokogiri from 1.8.2 to 1.8.5 (#1026) Bumps [nokogiri](https://github.com/sparklemotion/nokogiri) from 1.8.2 to 1.8.5. **This update includes security fixes.** - [Release notes](https://github.com/sparklemotion/nokogiri/releases) - [Changelog](https://github.com/sparklemotion/nokogiri/blob/master/CHANGELOG.md) - [Commits](sparklemotion/nokogiri@v1.8.2...v1.8.5) Signed-off-by: dependabot[bot] <support@dependabot.com> * Update link in .editorconfig to https (#1049) * Fix lowercase "c" in "WooCommerce". (#1043) * [Security] Bump ffi from 1.9.17 to 1.9.25 (#1017) Bumps [ffi](https://github.com/ffi/ffi) from 1.9.17 to 1.9.25. **This update includes security fixes.** - [Release notes](https://github.com/ffi/ffi/releases) - [Changelog](https://github.com/ffi/ffi/blob/master/CHANGELOG.md) - [Commits](ffi/ffi@1.9.17...1.9.25) Signed-off-by: dependabot[bot] <support@dependabot.com> * [Security] Bump rack from 2.0.5 to 2.0.6 (#1038) Bumps [rack](https://github.com/rack/rack) from 2.0.5 to 2.0.6. **This update includes security fixes.** - [Release notes](https://github.com/rack/rack/releases) - [Changelog](https://github.com/rack/rack/blob/master/CHANGELOG.md) - [Commits](rack/rack@2.0.5...2.0.6) Signed-off-by: dependabot[bot] <support@dependabot.com> * Bundle update; upgrade middleman, add sass gem Patch taken from #1092, thanks jakemack * Update to bundler 2.0 in travis.yml * Update issue templates * updated config.rb to activate asset_hash (#1076) * change example link correctly (#1130) * Change default value of base fork in PR template (#1137) * Updated README.md from lord/slate to slatedocs/slate (#1140) * Update url for travis badge * [Security] Upgrade nokogiri to 1.10.4 (#1150) * Cut version 2.4.0 * Use the full Apache License 2.0 text in LICENSE Per the Apache Software Foundation guidelines for applying the Apache License 2.0: https://www.apache.org/foundation/license-faq.html#Apply-My-Software > You should include a copy of the Apache License, typically in a file called LICENSE, in your work, and consider also including a NOTICE file. * Update GitHub Links on example generated site (#1196) * Update Vagrantfile to Ubuntu 18.04 (#1158) * Slate 2.4 breaks vagrant * Update Vagrantfile * Update Vagrantfile * Ignore generated log file from running Vagrant * Update tested versions of ruby on Travis (#1160) * Fully parse arguments first in deploy (#1153) * Do not build sources when using --help * Use variables for build/push if statements * fix error message * List maintainers in README (#1164) * Install nodejs in Vagrantfile (#1202) Co-authored-by: Matthew Peveler <matt.peveler@gmail.com> * add Dockerfile (#1124) * add Dockerfile add Dockerfile * Update Dockerfile Co-authored-by: Matthew Peveler <matt.peveler@gmail.com> * add instructions to running docker to README Signed-off-by: Matthew Peveler <matt.peveler@gmail.com> * Remove line in README about Docker wiki Signed-off-by: Matthew Peveler <matt.peveler@gmail.com> * update middleman dep to 4.3.6 Signed-off-by: Matthew Peveler <matt.peveler@gmail.com> * update middleman-syntax and rouge to ~>3.2 Signed-off-by: Matthew Peveler <matt.peveler@gmail.com> * update nokogiri to ~> 1.10.8 Signed-off-by: Matthew Peveler <matt.peveler@gmail.com> * add 2.5.0 release to changelog Signed-off-by: Matthew Peveler <matt.peveler@gmail.com> * update screenshot in README with new rouge styling (#1228) Signed-off-by: Matthew Peveler <matt.peveler@gmail.com> * fix bc style breaks from rouge 3.x (#1226) * fix bc style breaks from rouge 3.x Signed-off-by: Matthew Peveler <matt.peveler@gmail.com> * use bright_pink for Name::Label Signed-off-by: Matthew Peveler <matt.peveler@gmail.com> * Change instructions to use templates instead of forking (#1234) * disable asset hash for woff and woff2 files out of the box (#1231) Signed-off-by: Matthew Peveler <matt.peveler@gmail.com> * switch to using debian for docker base for bash (#1233) Signed-off-by: Matthew Peveler <matt.peveler@gmail.com> * update sassc to 2.3.0 in Gemfile.lock Signed-off-by: Matthew Peveler <matt.peveler@gmail.com> * v2.6.0 release Signed-off-by: Matthew Peveler <matt.peveler@gmail.com> * Update bug report templates, remove links to Spectrum (#1239) * Replace travis with github actions (#1240) Signed-off-by: Matthew Peveler <matt.peveler@gmail.com> * add missing middleman build step to deploy gh workflow Signed-off-by: Matthew Peveler <matt.peveler@gmail.com> * Replace README Getting Started with links to wiki (#1246) * Bump middleman from 4.3.6 to 4.3.7 (#1247) Bumps [middleman](https://github.com/middleman/middleman) from 4.3.6 to 4.3.7. - [Release notes](https://github.com/middleman/middleman/releases) - [Changelog](https://github.com/middleman/middleman/blob/v4.3.7/CHANGELOG.md) - [Commits](middleman/middleman@v4.3.6...v4.3.7) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com> * cut v2.6.1 release (#1249) Signed-off-by: Matthew Peveler <matt.peveler@gmail.com> * Fix broken "Getting Started" link in README (#1251) * Fix link to wiki in README (#1253) * master -> main (#1264) * Update deploy.yml (#1265) master -> main branch * Remove outdated special thanks section: README.md (#1267) Fixes #1243 * Fix username typo in changelog (#1256) Correct Github username to jakemack from jackmack * Update JavaScript dependencies (#1248) Signed-off-by: Mike Ralphson <mike.ralphson@gmail.com> * Bump rouge from 3.17.0 to 3.19.0 (#1242) Bumps [rouge](https://github.com/rouge-ruby/rouge) from 3.17.0 to 3.19.0. - [Release notes](https://github.com/rouge-ruby/rouge/releases) - [Changelog](https://github.com/rouge-ruby/rouge/blob/master/CHANGELOG.md) - [Commits](rouge-ruby/rouge@v3.17.0...v3.19.0) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com> * mark files under source/javascripts/lib as vendored by GitHub statistics Signed-off-by: Matthew Peveler <matt.peveler@gmail.com> * Bump redcarpet from 3.4.0 to 3.5.0 (#1241) Bumps [redcarpet](https://github.com/vmg/redcarpet) from 3.4.0 to 3.5.0. - [Release notes](https://github.com/vmg/redcarpet/releases) - [Changelog](https://github.com/vmg/redcarpet/blob/master/CHANGELOG.md) - [Commits](vmg/redcarpet@v3.4.0...v3.5.0) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com> * Bump rouge from 3.19.0 to 3.20.0 (#1260) Bumps [rouge](https://github.com/rouge-ruby/rouge) from 3.19.0 to 3.20.0. - [Release notes](https://github.com/rouge-ruby/rouge/releases) - [Changelog](https://github.com/rouge-ruby/rouge/blob/master/CHANGELOG.md) - [Commits](rouge-ruby/rouge@v3.19.0...v3.20.0) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com> * [Security] Bump rack from 2.2.2 to 2.2.3 (#1262) Bumps [rack](https://github.com/rack/rack) from 2.2.2 to 2.2.3. **This update includes a security fix.** - [Release notes](https://github.com/rack/rack/releases) - [Changelog](https://github.com/rack/rack/blob/master/CHANGELOG.md) - [Commits](rack/rack@v2.2.2...2.2.3) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com> * use different rouge theme for printing (#1259) Signed-off-by: Matthew Peveler <matt.peveler@gmail.com> * add copy to clipboard icon to code boxes (#1258) Signed-off-by: Matthew Peveler <matt.peveler@gmail.com> * Fix handling ToC selectors that contain punctuation (#1109) Tools like go-swag can produce schemas with IDs that contain '.' and other characters that are used in CSS notation. Those IDs can't be used properly in a jQuery selector unless the special characters are escaped. Co-authored-by: Matthew Peveler <matt.peveler@gmail.com> * fix language bar truncating long list of langs (#1266) Signed-off-by: Matthew Peveler <matt.peveler@gmail.com> * Strip HTML tags from ToC element with regex before showing in title bar (#1120) * cut 2.7.0 release (#1268) Signed-off-by: Matthew Peveler <matt.peveler@gmail.com> * Remove extra space before date for 2.7.0 Signed-off-by: Matthew Peveler <matt.peveler@gmail.com> * Fix link from master to main branch Signed-off-by: Matthew Peveler <matt.peveler@gmail.com> * Remove merge conflict lines from README (#1274) * Bump middleman from 4.3.7 to 4.3.8 (#1302) Bumps [middleman](https://github.com/middleman/middleman) from 4.3.7 to 4.3.8. - [Release notes](https://github.com/middleman/middleman/releases) - [Changelog](https://github.com/middleman/middleman/blob/master/CHANGELOG.md) - [Commits](middleman/middleman@v4.3.7...v4.3.8) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com> * cut 2.7.1 release Signed-off-by: Matthew Peveler <matt.peveler@gmail.com> Co-authored-by: Jay Thomas <jay@gfax.ch> Co-authored-by: Robert Lord <robert@lord.io> Co-authored-by: Vladimir Morozov <greenhost87@gmail.com> Co-authored-by: Martius <martius.lim.2015@sis.smu.edu.sg> Co-authored-by: Gregor Martynus <gregor@martynus.net> Co-authored-by: Emir Ribić <ribice@gmail.com> Co-authored-by: Tomi Takussaari <tomi.takussaari@gmail.com> Co-authored-by: Dan Levy <397632+justsml@users.noreply.github.com> Co-authored-by: Samuel Cousin <hello@samuelcousin.com> Co-authored-by: Andrey Fedorov <me@anfedorov.com> Co-authored-by: al-tr <al-tr@users.noreply.github.com> Co-authored-by: Jerome Dahdah <developer@dahdah.org> Co-authored-by: Sebastian Zaremba <1636476+vassyz@users.noreply.github.com> Co-authored-by: Ricardo Castro <mccricardo@users.noreply.github.com> Co-authored-by: Grey Baker <greysteil@gmail.com> Co-authored-by: Nick Busey <NickBusey@users.noreply.github.com> Co-authored-by: Christian Oliff <christianoliff@yahoo.com> Co-authored-by: Jeff Stieler <jeff.m.stieler@gmail.com> Co-authored-by: Dan <48282179+dan-os@users.noreply.github.com> Co-authored-by: Sam Gilman <thenengah@gmail.com> Co-authored-by: daniel-korbit <daniel.ji@korbit.co.kr> Co-authored-by: Arun <slash-arun@outlook.com> Co-authored-by: Gustavo Gawryszewski <318831+gawry@users.noreply.github.com> Co-authored-by: Matthew Peveler <matt.peveler@gmail.com> Co-authored-by: BigBlueHat <byoung@bigbluehat.com> Co-authored-by: Alex Mayer <amayer5125@gmail.com> Co-authored-by: Mike Ralphson <mike.ralphson@gmail.com> Co-authored-by: Brad Thurber <brad.thurber@gmail.com> Co-authored-by: Fernando Aguilar <fernando@recargo.com> Co-authored-by: KaliArch <18329903316@163.com> Co-authored-by: lord <lord@users.noreply.github.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com> Co-authored-by: Ritesh Kumar <ritesh99rakesh@gmail.com> Co-authored-by: Simon Marcus <simon@pippa.io> Co-authored-by: jakemack <jakemack@gmail.com> Co-authored-by: Caleb Crane <caleb@gru.is> Co-authored-by: Andrew Lloyd Cartwright <andrewlloydcartwright+atlc@gmail.com> Co-authored-by: McKay Ward <mckay@mckayward.com>
fulf
referenced
this pull request
in remotelock/slate
Feb 15, 2023
* Update Vagrantfile to Ubuntu 18.04 (#1158) * Slate 2.4 breaks vagrant * Update Vagrantfile * Update Vagrantfile * Ignore generated log file from running Vagrant * Update tested versions of ruby on Travis (#1160) * Fully parse arguments first in deploy (#1153) * Do not build sources when using --help * Use variables for build/push if statements * fix error message * List maintainers in README (#1164) * Install nodejs in Vagrantfile (#1202) Co-authored-by: Matthew Peveler <matt.peveler@gmail.com> * add Dockerfile (#1124) * add Dockerfile add Dockerfile * Update Dockerfile Co-authored-by: Matthew Peveler <matt.peveler@gmail.com> * add instructions to running docker to README Signed-off-by: Matthew Peveler <matt.peveler@gmail.com> * Remove line in README about Docker wiki Signed-off-by: Matthew Peveler <matt.peveler@gmail.com> * update middleman dep to 4.3.6 Signed-off-by: Matthew Peveler <matt.peveler@gmail.com> * update middleman-syntax and rouge to ~>3.2 Signed-off-by: Matthew Peveler <matt.peveler@gmail.com> * update nokogiri to ~> 1.10.8 Signed-off-by: Matthew Peveler <matt.peveler@gmail.com> * add 2.5.0 release to changelog Signed-off-by: Matthew Peveler <matt.peveler@gmail.com> * update screenshot in README with new rouge styling (#1228) Signed-off-by: Matthew Peveler <matt.peveler@gmail.com> * fix bc style breaks from rouge 3.x (#1226) * fix bc style breaks from rouge 3.x Signed-off-by: Matthew Peveler <matt.peveler@gmail.com> * use bright_pink for Name::Label Signed-off-by: Matthew Peveler <matt.peveler@gmail.com> * Change instructions to use templates instead of forking (#1234) * disable asset hash for woff and woff2 files out of the box (#1231) Signed-off-by: Matthew Peveler <matt.peveler@gmail.com> * switch to using debian for docker base for bash (#1233) Signed-off-by: Matthew Peveler <matt.peveler@gmail.com> * update sassc to 2.3.0 in Gemfile.lock Signed-off-by: Matthew Peveler <matt.peveler@gmail.com> * v2.6.0 release Signed-off-by: Matthew Peveler <matt.peveler@gmail.com> * Update bug report templates, remove links to Spectrum (#1239) * Replace travis with github actions (#1240) Signed-off-by: Matthew Peveler <matt.peveler@gmail.com> * add missing middleman build step to deploy gh workflow Signed-off-by: Matthew Peveler <matt.peveler@gmail.com> * Replace README Getting Started with links to wiki (#1246) * Bump middleman from 4.3.6 to 4.3.7 (#1247) Bumps [middleman](https://github.com/middleman/middleman) from 4.3.6 to 4.3.7. - [Release notes](https://github.com/middleman/middleman/releases) - [Changelog](https://github.com/middleman/middleman/blob/v4.3.7/CHANGELOG.md) - [Commits](middleman/middleman@v4.3.6...v4.3.7) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com> * cut v2.6.1 release (#1249) Signed-off-by: Matthew Peveler <matt.peveler@gmail.com> * Fix broken "Getting Started" link in README (#1251) * Fix link to wiki in README (#1253) * master -> main (#1264) * Update deploy.yml (#1265) master -> main branch * Remove outdated special thanks section: README.md (#1267) Fixes #1243 * Fix username typo in changelog (#1256) Correct Github username to jakemack from jackmack * Update JavaScript dependencies (#1248) Signed-off-by: Mike Ralphson <mike.ralphson@gmail.com> * Bump rouge from 3.17.0 to 3.19.0 (#1242) Bumps [rouge](https://github.com/rouge-ruby/rouge) from 3.17.0 to 3.19.0. - [Release notes](https://github.com/rouge-ruby/rouge/releases) - [Changelog](https://github.com/rouge-ruby/rouge/blob/master/CHANGELOG.md) - [Commits](rouge-ruby/rouge@v3.17.0...v3.19.0) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com> * mark files under source/javascripts/lib as vendored by GitHub statistics Signed-off-by: Matthew Peveler <matt.peveler@gmail.com> * Bump redcarpet from 3.4.0 to 3.5.0 (#1241) Bumps [redcarpet](https://github.com/vmg/redcarpet) from 3.4.0 to 3.5.0. - [Release notes](https://github.com/vmg/redcarpet/releases) - [Changelog](https://github.com/vmg/redcarpet/blob/master/CHANGELOG.md) - [Commits](vmg/redcarpet@v3.4.0...v3.5.0) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com> * Bump rouge from 3.19.0 to 3.20.0 (#1260) Bumps [rouge](https://github.com/rouge-ruby/rouge) from 3.19.0 to 3.20.0. - [Release notes](https://github.com/rouge-ruby/rouge/releases) - [Changelog](https://github.com/rouge-ruby/rouge/blob/master/CHANGELOG.md) - [Commits](rouge-ruby/rouge@v3.19.0...v3.20.0) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com> * [Security] Bump rack from 2.2.2 to 2.2.3 (#1262) Bumps [rack](https://github.com/rack/rack) from 2.2.2 to 2.2.3. **This update includes a security fix.** - [Release notes](https://github.com/rack/rack/releases) - [Changelog](https://github.com/rack/rack/blob/master/CHANGELOG.md) - [Commits](rack/rack@v2.2.2...2.2.3) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com> * use different rouge theme for printing (#1259) Signed-off-by: Matthew Peveler <matt.peveler@gmail.com> * add copy to clipboard icon to code boxes (#1258) Signed-off-by: Matthew Peveler <matt.peveler@gmail.com> * Fix handling ToC selectors that contain punctuation (#1109) Tools like go-swag can produce schemas with IDs that contain '.' and other characters that are used in CSS notation. Those IDs can't be used properly in a jQuery selector unless the special characters are escaped. Co-authored-by: Matthew Peveler <matt.peveler@gmail.com> * fix language bar truncating long list of langs (#1266) Signed-off-by: Matthew Peveler <matt.peveler@gmail.com> * Strip HTML tags from ToC element with regex before showing in title bar (#1120) * cut 2.7.0 release (#1268) Signed-off-by: Matthew Peveler <matt.peveler@gmail.com> * Remove extra space before date for 2.7.0 Signed-off-by: Matthew Peveler <matt.peveler@gmail.com> * Fix link from master to main branch Signed-off-by: Matthew Peveler <matt.peveler@gmail.com> * Remove merge conflict lines from README (#1274) * Bump rouge from 3.20.0 to 3.21.0 (#1285) Bumps [rouge](https://github.com/rouge-ruby/rouge) from 3.20.0 to 3.21.0. - [Release notes](https://github.com/rouge-ruby/rouge/releases) - [Changelog](https://github.com/rouge-ruby/rouge/blob/master/CHANGELOG.md) - [Commits](rouge-ruby/rouge@v3.20.0...v3.21.0) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com> * Bump nokogiri from 1.10.9 to 1.10.10 (#1282) Bumps [nokogiri](https://github.com/sparklemotion/nokogiri) from 1.10.9 to 1.10.10. - [Release notes](https://github.com/sparklemotion/nokogiri/releases) - [Changelog](https://github.com/sparklemotion/nokogiri/blob/master/CHANGELOG.md) - [Commits](sparklemotion/nokogiri@v1.10.9...v1.10.10) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com> * trim ending newline on copied code (#1296) Signed-off-by: Matthew Peveler <matt.peveler@gmail.com> * Rework docker image to be easier to use for development and deployment (#1297) Signed-off-by: Matthew Peveler <matt.peveler@gmail.com> * Bump middleman from 4.3.7 to 4.3.8 (#1302) Bumps [middleman](https://github.com/middleman/middleman) from 4.3.7 to 4.3.8. - [Release notes](https://github.com/middleman/middleman/releases) - [Changelog](https://github.com/middleman/middleman/blob/master/CHANGELOG.md) - [Commits](middleman/middleman@v4.3.7...v4.3.8) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com> * Bump middleman from 4.3.7 to 4.3.8 (#1302) Bumps [middleman](https://github.com/middleman/middleman) from 4.3.7 to 4.3.8. - [Release notes](https://github.com/middleman/middleman/releases) - [Changelog](https://github.com/middleman/middleman/blob/master/CHANGELOG.md) - [Commits](middleman/middleman@v4.3.7...v4.3.8) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com> * cut 2.7.1 release Signed-off-by: Matthew Peveler <matt.peveler@gmail.com> * Add deploy to gh-pages for dev branch (#1305) Signed-off-by: Matthew Peveler <matt.peveler@gmail.com> * update actions/cache to v2 for gh workflows (#1314) Signed-off-by: Matthew Peveler <matt.peveler@gmail.com> * Remove outdated special thanks section in README.md (#1307) * Bump rouge from 3.21.0 to 3.23.0 (#1311) Bumps [rouge](https://github.com/rouge-ruby/rouge) from 3.21.0 to 3.23.0. - [Release notes](https://github.com/rouge-ruby/rouge/releases) - [Changelog](https://github.com/rouge-ruby/rouge/blob/master/CHANGELOG.md) - [Commits](rouge-ruby/rouge@v3.21.0...v3.23.0) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com> * Bump middleman from 4.3.8 to 4.3.10 (#1316) Bumps [middleman](https://github.com/middleman/middleman) from 4.3.8 to 4.3.10. - [Release notes](https://github.com/middleman/middleman/releases) - [Changelog](https://github.com/middleman/middleman/blob/master/CHANGELOG.md) - [Commits](middleman/middleman@v4.3.8...v4.3.10) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com> * Bump middleman from 4.3.10 to 4.3.11 (#1319) Bumps [middleman](https://github.com/middleman/middleman) from 4.3.10 to 4.3.11. - [Release notes](https://github.com/middleman/middleman/releases) - [Changelog](https://github.com/middleman/middleman/blob/master/CHANGELOG.md) - [Commits](https://github.com/middleman/middleman/commits) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com> * upgrade lunr to 2.3.9 (#1325) Signed-off-by: Mike Ralphson <mike.ralphson@gmail.com> * Bump rouge from 3.23.0 to 3.24.0 (#1334) Bumps [rouge](https://github.com/rouge-ruby/rouge) from 3.23.0 to 3.24.0. - [Release notes](https://github.com/rouge-ruby/rouge/releases) - [Changelog](https://github.com/rouge-ruby/rouge/blob/master/CHANGELOG.md) - [Commits](rouge-ruby/rouge@v3.23.0...v3.24.0) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com> * Dockerfile: allow Docker to cache build steps (#1336) - By having a `COPY . xx` step before installing dependencies, we rob Docker of the opportunity to cache downloading and building dependencies if we make any changes to any files in the repository. By copying only Gemfiles before the build step, we only require Docker to rebuild dependencies when the Gemfiles have changed. Co-authored-by: Matthew Peveler <matt.peveler@gmail.com> * add docker deploy step to github workflows (#1321) Signed-off-by: Matthew Peveler <matt.peveler@gmail.com> * Fix shell code examples to have line continuations (#1324) * cut 2.8.0 release Signed-off-by: Matthew Peveler <matt.peveler@gmail.com> * Update command to fetch latest commit for issue template (#1342) Signed-off-by: Matthew Peveler <matt.peveler@gmail.com> * add docker version badge to README Signed-off-by: Matthew Peveler <matt.peveler@gmail.com> * Fix vagrant issue: use exact version of bundler (#1355) I was getting this error, ''Cant find gem bundler (>= 0.a) with executable bundle', after I ran `vagrant up`. The version of RubyGem installed in the vagrant box cannot find the exact version of Bundler listed in Gemfile.lock. This solution ensures that the exact bundler version installed in Gemfile.lock is installed before running `bundle install`. The issue is solved in RubyGems >= 2.7.10 and Ruby >=2.6.3. This solution ensures a fix without requiring a more complicated upgrade. More information found here: https://bundler.io/blog/2019/05/14/solutions-for-cant-find-gem-bundler-with-executable-bundle.html * Bump rouge from 3.24.0 to 3.25.0 (#1343) Bumps [rouge](https://github.com/rouge-ruby/rouge) from 3.24.0 to 3.25.0. - [Release notes](https://github.com/rouge-ruby/rouge/releases) - [Changelog](https://github.com/rouge-ruby/rouge/blob/master/CHANGELOG.md) - [Commits](rouge-ruby/rouge@v3.24.0...v3.25.0) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com> * Bump rouge from 3.25.0 to 3.26.0 (#1350) Bumps [rouge](https://github.com/rouge-ruby/rouge) from 3.25.0 to 3.26.0. - [Release notes](https://github.com/rouge-ruby/rouge/releases) - [Changelog](https://github.com/rouge-ruby/rouge/blob/master/CHANGELOG.md) - [Commits](rouge-ruby/rouge@v3.25.0...v3.26.0) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com> * Bump redcarpet from 3.5.0 to 3.5.1 (#1352) Bumps [redcarpet](https://github.com/vmg/redcarpet) from 3.5.0 to 3.5.1. - [Release notes](https://github.com/vmg/redcarpet/releases) - [Changelog](https://github.com/vmg/redcarpet/blob/master/CHANGELOG.md) - [Commits](vmg/redcarpet@v3.5.0...v3.5.1) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com> * Update link to ruby languages in README (#1351) Signed-off-By: Matthew Peveler <matt.peveler@gmail.com> * Remove scale from README examples (#1363) They've switched to readme.io * Drop support for Ruby 2.3 and 2.4 (#1366) Signed-off-By: Matthew Peveler <matt.peveler@gmail.com> * Update supported ruby version in Gemfile Signed-off-by: Matthew Peveler <matt.peveler@gmail.com> * [Security] Bump nokogiri from 1.10.10 to 1.11.0 (#1360) Bumps [nokogiri](https://github.com/sparklemotion/nokogiri) from 1.10.10 to 1.11.0. **This update includes a security fix.** - [Release notes](https://github.com/sparklemotion/nokogiri/releases) - [Changelog](https://github.com/sparklemotion/nokogiri/blob/master/CHANGELOG.md) - [Commits](sparklemotion/nokogiri@v1.10.10...v1.11.0) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com> * Bump nokogiri from 1.11.0 to 1.11.1 (#1370) Bumps [nokogiri](https://github.com/sparklemotion/nokogiri) from 1.11.0 to 1.11.1. - [Release notes](https://github.com/sparklemotion/nokogiri/releases) - [Changelog](https://github.com/sparklemotion/nokogiri/blob/main/CHANGELOG.md) - [Commits](sparklemotion/nokogiri@v1.11.0...v1.11.1) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com> * Update changelog for 2.9.0 Signed-off-by: Matthew Peveler <matt.peveler@gmail.com> * Specify slate is not Ruby 3.0 compatible Signed-off-by: Matthew Peveler <matt.peveler@gmail.com> * Fix changelog entry for 2.9.0 * Add guards around localStorage in case user disables it (#1399) Signed-off-by: Matthew Peveler <matt.peveler@gmail.com> * cut 2.9.1 release (#1400) Signed-off-by: Matthew Peveler <matt.peveler@gmail.com> * Bump nokogiri from 1.11.1 to 1.11.2 (#1407) Bumps [nokogiri](https://github.com/sparklemotion/nokogiri) from 1.11.1 to 1.11.2. - [Release notes](https://github.com/sparklemotion/nokogiri/releases) - [Changelog](https://github.com/sparklemotion/nokogiri/blob/main/CHANGELOG.md) - [Commits](sparklemotion/nokogiri@v1.11.1...v1.11.2) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com> * [Security] Bump kramdown from 2.3.0 to 2.3.1 (#1416) Bumps [kramdown](https://github.com/gettalong/kramdown) from 2.3.0 to 2.3.1. **This update includes a security fix.** - [Release notes](https://github.com/gettalong/kramdown/releases) - [Changelog](https://github.com/gettalong/kramdown/blob/master/doc/news.page) - [Commits](https://github.com/gettalong/kramdown/commits) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com> * cut 2.9.2 release Signed-off-by: Matthew Peveler <matt.peveler@gmail.com> * Bump nokogiri from 1.11.2 to 1.11.3 (#1425) Bumps [nokogiri](https://github.com/sparklemotion/nokogiri) from 1.11.2 to 1.11.3. - [Release notes](https://github.com/sparklemotion/nokogiri/releases) - [Changelog](https://github.com/sparklemotion/nokogiri/blob/main/CHANGELOG.md) - [Commits](sparklemotion/nokogiri@v1.11.2...v1.11.3) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com> * Make slate compatible with ruby 3.0.0 (#1424) * Add git to Dockerfile (#1426) Signed-off-by: Matthew Peveler <matt.peveler@gmail.com> * Bump middleman from `0c950d8` to `d180ca3` (#1427) Bumps [middleman](https://github.com/middleman/middleman) from `0c950d8` to `d180ca3`. - [Release notes](https://github.com/middleman/middleman/releases) - [Commits](middleman/middleman@0c950d8...d180ca3) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com> * cut 2.10.0 release (#1428) Signed-off-by: Matthew Peveler <matt.peveler@gmail.com> * Upgrade to GitHub-native Dependabot (#1435) Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com> * Bump nokogiri from 1.11.3 to 1.11.5 (#1446) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump middleman-autoprefixer from 2.10.1 to 3.0.0 (#1445) Bumps [middleman-autoprefixer](https://github.com/middleman/middleman-autoprefixer) from 2.10.1 to 3.0.0. - [Release notes](https://github.com/middleman/middleman-autoprefixer/releases) - [Changelog](https://github.com/middleman/middleman-autoprefixer/blob/master/CHANGELOG.md) - [Commits](middleman/middleman-autoprefixer@v2.10.1...v3.0.0) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump nokogiri from 1.11.5 to 1.11.6 (#1450) Bumps [nokogiri](https://github.com/sparklemotion/nokogiri) from 1.11.5 to 1.11.6. - [Release notes](https://github.com/sparklemotion/nokogiri/releases) - [Changelog](https://github.com/sparklemotion/nokogiri/blob/main/CHANGELOG.md) - [Commits](sparklemotion/nokogiri@v1.11.5...v1.11.6) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Support specifying custom meta tags in YAML (#1453) * Set minimum supported version of nokogiri to 1.11.4 Signed-off-by: Matthew Peveler <matt.peveler@gmail.com> * Add sample usage of meta frontmatter to layout Signed-off-by: Matthew Peveler <matt.peveler@gmail.com> * Update jquery to 3.6.0 (#1458) * Bump middleman from d180ca3 to 4.4.0 (#1474) * Bump nokogiri from 1.11.6 to 1.11.7 (#1459) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Fix incorrect ruby-version parameter in deploy GitHub Actions (#1489) * Bump addressable from 2.7.0 to 2.8.0 (#1484) Co-authored-by: Matthew Peveler <matt.peveler@gmail.com> * Bump nokogiri from 1.11.7 to 1.12.1 (#1492) Bumps [nokogiri](https://github.com/sparklemotion/nokogiri) from 1.11.7 to 1.12.1. - [Release notes](https://github.com/sparklemotion/nokogiri/releases) - [Changelog](https://github.com/sparklemotion/nokogiri/blob/main/CHANGELOG.md) - [Commits](sparklemotion/nokogiri@v1.11.7...v1.12.1) --- updated-dependencies: - dependency-name: nokogiri dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump nokogiri from 1.12.1 to 1.12.3 (#1496) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * cut 2.11.0 release (#1455) * Bump nokogiri from 1.12.3 to 1.12.4 (#1499) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Add CoinAPI to README examples (#1497) * Bump rouge from 3.26.0 to 3.26.1 (#1507) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump nokogiri from 1.12.4 to 1.12.5 (#1511) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump ffi from 1.15.0 to 1.15.4 (#1510) * Limit GITHUB_TOKEN scope for workflows (#1522) * Ignore more files in docker images (#1523) * Bump middleman from 4.4.0 to 4.4.2 (#1530) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump version to 2.12.0 (#1524) * Bump rouge from 3.26.1 to 3.27.0 (#1544) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Add ruby 3.1 to test suite (#1553) * Bump rouge from 3.27.0 to 3.28.0 (#1574) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Add support to build multi-arch docker images (#1587) * Drop support for Ruby 2.5 (#1588) * Bump nokogiri from 1.12.5 to 1.13.3 (#1585) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump nokogiri from 1.13.3 to 1.13.4 (#1604) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Remove VOLUME declaration from Dockerfile (#1607) * Bump version to 2.13.0 (#1606) * Remove extra * from changelog date * Fix version ranges for rouge and nokogiri in 2.13.0 release * Bump nokogiri from 1.13.4 to 1.13.5 (#1612) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Fix Vagrantfile gem install for ruby >= 2.6 (#1618) * Bump rouge from 3.28.0 to 3.29.0 (#1621) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump nokogiri from 1.13.5 to 1.13.6 (#1614) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Expand deprecated git.io links to full url (#1611) * Bump nokogiri from 1.13.6 to 1.13.7 (#1639) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump nokogiri from 1.13.7 to 1.13.8 (#1643) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump rouge from 3.29.0 to 3.30.0 (#1646) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump middleman-syntax from 3.2.0 to 3.3.0 (#1648) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Disable file watcher in run_build() for the sake of qemu on arm64 (#1658) * Bump nokogiri from 1.13.8 to 1.13.9 (#1676) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump redcarpet from 3.5.1 to 3.6.0 (#1715) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump webrick from 1.7.0 to 1.8.1 (#1713) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump middleman from 4.4.2 to 4.4.3 (#1682) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Matthew Peveler <matt.peveler@gmail.com> * Add margin to paragraph following code-block on phones (#1637) * Bump version to 2.13.1 (#1661) --------- Signed-off-by: Matthew Peveler <matt.peveler@gmail.com> Signed-off-by: Mike Ralphson <mike.ralphson@gmail.com> Co-authored-by: Brad Thurber <brad.thurber@gmail.com> Co-authored-by: Matthew Peveler <matt.peveler@gmail.com> Co-authored-by: Robert Lord <robert@lord.io> Co-authored-by: Fernando Aguilar <fernando@recargo.com> Co-authored-by: KaliArch <18329903316@163.com> Co-authored-by: lord <lord@users.noreply.github.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com> Co-authored-by: Ritesh Kumar <ritesh99rakesh@gmail.com> Co-authored-by: Simon Marcus <simon@pippa.io> Co-authored-by: Mike Ralphson <mike.ralphson@gmail.com> Co-authored-by: jakemack <jakemack@gmail.com> Co-authored-by: Caleb Crane <caleb@gru.is> Co-authored-by: Andrew Lloyd Cartwright <andrewlloydcartwright+atlc@gmail.com> Co-authored-by: McKay Ward <mckay@mckayward.com> Co-authored-by: Michael Bang <mic@vbang.dk> Co-authored-by: Victor E F <victorevector@gmail.com> Co-authored-by: Courtenay <hdsheena@users.noreply.github.com> Co-authored-by: Shaun VanWeelden <shaun.vanweelden@scaleapi.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: King'ori Maina <j@kingori.co> Co-authored-by: Artur Pietrzyk <Svisstack@users.noreply.github.com> Co-authored-by: Daniel Grieve <dnlgrv@hey.com> Co-authored-by: enomotodev <enomoto.dev@gmail.com> Co-authored-by: Anthony Emengo <anthonyemengojr@gmail.com> Co-authored-by: Cyb0rk <Cyb0rk@users.noreply.github.com> Co-authored-by: Hunter <hunterray555@gmail.com> Co-authored-by: Anastas Dancha <anapsix@random.io> Co-authored-by: Thomas Hunter II <me@thomashunter.name>
vh
referenced
this pull request
in nitrotranslate/developer
May 3, 2024
* fix bc style breaks from rouge 3.x Signed-off-by: Matthew Peveler <matt.peveler@gmail.com> * use bright_pink for Name::Label Signed-off-by: Matthew Peveler <matt.peveler@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The newest version of Rouge (somewhere in the 3.x release line) did the following changes:
Name::Labelinstead ofLiteral::String(and so can be styled different color from the values)<div class='highlight'>around the<pre class='highlight'>This PR fixes these to be inline with how Slate was doing things with older versions of Rouge (while still retaining all of the fancy new supported languages and improved parsers).
Fixes #1225
screenshot of differences:
master:
after pr:
