Skip to content

Conversation

jakubmacek
Copy link
Contributor

I have found your project through reddit. I have used https://github.com/ivaylokenov/AspNet.Mvc.TypedRouting to achieve similar effects, but it is a really good idea to do this using a code generator.

I encountered two problems in my project though - I use nested classes (as parameters) and partial classes (as controllers), so I had implement support for it.

I had to rewrite thee GetFullNamespace method, because the switch expression in it became too complicated to be debuggable (at least for me).

@sleeuwen sleeuwen merged commit 644d0dd into sleeuwen:master Mar 14, 2021
@sleeuwen
Copy link
Owner

Hi @jakubmacek,

First of all, thank you for trying out the project and considering replacing your current library with it.

The changes you made totally make sense and I really appreciate you also took the time to add tests for it.
I've pushed an update with your changes to nuget as v0.3.0 so that should be available shortly, so you should be able to use it in your projects with that version. If you encounter any other issues, feel free to open an issue or create a new PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants