x11: fix break screen on multiple monitors #794
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See the added comment for details.
|
I've tested this on XFCE (X11) with two screens - I can confirm this fixes the issue. |
Maybe blaming this on GTK was too hasty - it only seems to happen on XFCE. |
|
@deltragon It works! Tested in Linux Mint 22.2 XFCE. |
|
I wonder, how did you even figure out that switching the order of the two lines would fix the issue? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #776.
Apparently GTK's fullscreen_on_monitor works differently on X11 if the window already exists vs before it is created.
(This however may just be a GTK bug too).
On Wayland either works fine in my testing.