Elements with VR UN (explicit VR) now keep this VR in ParseFlow #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KarlSjostrand
commented
Aug 6, 2018
| currentHeader = Some(header) | ||
| currentModification = Some(tagModification) | ||
| value = ByteString.empty | ||
| Nil |
There was a problem hiding this comment.
The above is an unrelated fix that slipped in. Else-part of this if-else cannot happen.
KarlSjostrand
commented
Aug 6, 2018
| else | ||
| Some(HeaderPart(tag, updatedVr2, valueLength, isFmi = false, state.bigEndian, state.explicitVR, bytes)) | ||
| else { | ||
| val realVr = if (state.explicitVR) vr else updatedVr2 |
There was a problem hiding this comment.
This is the bug fix. If explicit VR, use the original VR from the binary data, not the VR based on the guessing that takes place above with updatedVr1 and updatedVr2.
Pull Request Test Coverage Report for Build 94
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This bug was messing with DICOM files with explicit VR that included elements with VR encoded as UN but which have known VRs according to the dictionary. The file in question included the element PatientIdentityRemoved which has VR CS according to the dictionary but was encoded with VR UN in the file. This bug fix makes sure the VR stays UN is these cases. ParseFlow should not change the data!