Skip to content

Conversation

dizys
Copy link
Contributor

@dizys dizys commented May 25, 2021

Fix #173 / #177.

Using null in number typed slideScale would also make Vue runtime type checking fail.

But notice this fix gives special meaning to value 0, replacing the original null.

@dizys
Copy link
Contributor Author

dizys commented May 25, 2021

I've tried replacing null with NaN instead, but NaN would require special comparison isNaN in order for SelectList in Settings.vue to work propertly with the checkmark class. So 0 is my best attempt so far.

@antfu antfu merged commit 596b4a7 into slidevjs:main May 25, 2021
@dizys dizys deleted the fix/funny-screen-scale branch May 25, 2021 07:57
antfu pushed a commit that referenced this pull request Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Slide appears in bottom right corner
2 participants