Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4.x Port of Fix for #2568 #2588

Merged
merged 4 commits into from Mar 2, 2019

Conversation

Projects
None yet
3 participants
@l0gicgate
Copy link
Contributor

commented Feb 22, 2019

This is a fix ported from 3.x to 4.x for #2568

I also added HeaderFunctions to HeaderStack and added PhpFunctionOverrides from #2520

I think this PR may need to be merged before #2587 if we want to avoid merge conflicts. I don't know for sure though.

@l0gicgate l0gicgate added the Slim 4 label Feb 23, 2019

@l0gicgate l0gicgate added this to the 4.0 milestone Feb 23, 2019

@l0gicgate l0gicgate changed the title 4.x - Fix for #2568 Port 4.x Port of Fix for #2568 Feb 23, 2019

@coveralls

This comment has been minimized.

Copy link

commented Feb 23, 2019

Coverage Status

Coverage decreased (-0.9%) to 98.485% when pulling f735bb6 on l0gicgate:4.x-RouterCacheFileImprovement into 5311e95 on slimphp:4.x.

l0gicgate added a commit to l0gicgate/Slim that referenced this pull request Feb 28, 2019

@akrabat

akrabat approved these changes Mar 2, 2019

@akrabat akrabat merged commit f735bb6 into slimphp:4.x Mar 2, 2019

1 of 2 checks passed

coverage/coveralls Coverage decreased (-0.9%) to 98.485%
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

akrabat added a commit that referenced this pull request Mar 2, 2019

@l0gicgate l0gicgate deleted the l0gicgate:4.x-RouterCacheFileImprovement branch Mar 2, 2019

@l0gicgate l0gicgate referenced this pull request Apr 25, 2019

Merged

Slim 4 Alpha Release #2665

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.