Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PHPStan v1.0 #3127

Merged
merged 6 commits into from
Nov 7, 2021
Merged

PHPStan v1.0 #3127

merged 6 commits into from
Nov 7, 2021

Conversation

t0mmy742
Copy link
Contributor

@t0mmy742 t0mmy742 commented Nov 4, 2021

I still need to add some unit tests before merging.

@coveralls
Copy link

coveralls commented Nov 4, 2021 •
edited
Loading

Coverage Status

Coverage remained the same at 100.0% when pulling 110d76d on t0mmy742:phpstan_v1 into a8e4ce9 on slimphp:4.x.

@l0gicgate
Copy link
Member

Thank you for this contribution @t0mmy742

We should add tests for the newly introduced if cases where we throw the exceptions before merging so we keep coverage at 100%

@t0mmy742
Copy link
Contributor Author

t0mmy742 commented Nov 4, 2021

@l0gicgate Yes, I planned to send a commit tomorrow 👍

@t0mmy742
Copy link
Contributor Author

t0mmy742 commented Nov 5, 2021

Tests added. PR ready !

@l0gicgate l0gicgate added this to the 4.10.0 milestone Nov 7, 2021
@l0gicgate l0gicgate merged commit e208383 into slimphp:4.x Nov 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@l0gicgate l0gicgate l0gicgate approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.10.0
Development

Successfully merging this pull request may close these issues.
3 participants
@t0mmy742 @coveralls @l0gicgate