Skip to content

Test against php 8.1 in not experimental mode#3124

Closed
sergiy-petrov wants to merge 2 commits intoslimphp:4.xfrom
sergiy-petrov:sergiy-petrov-patch-1
Closed

Test against php 8.1 in not experimental mode#3124
sergiy-petrov wants to merge 2 commits intoslimphp:4.xfrom
sergiy-petrov:sergiy-petrov-patch-1

Conversation

@sergiy-petrov
Copy link
Contributor

No description provided.

@coveralls
Copy link

coveralls commented Oct 27, 2021

Coverage Status

Coverage remained the same at 100.0% when pulling ffe6fd5 on sergiy-petrov:sergiy-petrov-patch-1 into a8e4ce9 on slimphp:4.x.

@t0mmy742
Copy link
Contributor

CI already passed successfully with PHP 8.1. It will not break anything.
PHP 8.1 is not official yet. It should be officially released Nov 25 2021 (but RC5 already released, so nothing should change but bugfix).
@l0gicgate do you think we should do analyses (PHPCS & PHPStan & coverage) on PHP 8.1 too ? Or maybe we should wait for official release.

@sergiy-petrov
Copy link
Contributor Author

@t0mmy742 I've added option to run phpstan on php 8.1 in separate branch (it's on my fork). Seems it has a lot of errors however job is passed. Not sure why does it behave like that. You could see it on my fork:

https://github.com/sergiy-petrov/Slim/runs/4046667668?check_suite_focus=true

@t0mmy742
Copy link
Contributor

It seems like phpstan is not ready for PHP 8.1 yet.
We should not do analyses on this version of PHP (I'm answering myself, I know x) )

@l0gicgate
Copy link
Member

It looks like PHPStan 1.0.0 was just released. Is that what we're waiting for? 🤔

@t0mmy742 t0mmy742 mentioned this pull request Nov 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants