Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Add programming languages to 'Projects' #40

Merged
merged 4 commits into from
Oct 17, 2020

Conversation

benji011
Copy link
Contributor

What

In https://portfolio.smakosh.com we have below:

Before

image

After

image

Why

I forked from this repo & added these changes and then figured this might be a cool thing to add here. If this is ok (or if it's not really needed) please let me know. Thanks!

@netlify
Copy link

netlify bot commented Oct 14, 2020

Deploy request for gatsby-portfolio-dev pending review.

Review with commit 97097a8

https://app.netlify.com/sites/gatsby-portfolio-dev/deploys

@vercel
Copy link

vercel bot commented Oct 14, 2020

@benji011 is attempting to deploy a commit to a Personal Account owned by Ismail Ghallou on Vercel.

@smakosh first needs to authorize it.

@vercel
Copy link

vercel bot commented Oct 17, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/smakosh/gatsby-portfolio-dev/1fqsk5x8e
✅ Preview: https://gatsby-portfolio-dev-git-add-programming-languages-graph-ql.smakosh.vercel.app

@smakosh smakosh added the enhancement New feature or request label Oct 17, 2020
@smakosh
Copy link
Owner

smakosh commented Oct 17, 2020

Hey @benji011 this looks cool actually, worried how it would look like when there are many, could you think of a way to handle the UI on that case?

@benji011
Copy link
Contributor Author

Hi @smakosh ! I thought about that so I set the condition to be languages: first 3. In the case it's none an empty string is returned.

I think setting just 1 may infact even be enough. Is this what you mean?

@smakosh
Copy link
Owner

smakosh commented Oct 17, 2020

Hi @smakosh ! I thought about that so I set the condition to be languages: first 3. In the case it's none an empty string is returned.

I think setting just 1 may infact even be enough. Is this what you mean?

Yup, correct! Let me review your code real quick

Copy link
Owner

@smakosh smakosh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the contribution @benji011 🚀

@smakosh smakosh merged commit f40c38d into smakosh:master Oct 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants