DotName componentization #176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, when serializing the name table, we'd store the "depth" of the currently serialized name, and during deserialization, we'd look at the previously deserialized name and take its prefix "depth" times in hope that we'll obtain the correct prefix. That usually works, but fails with weird names using the `$` character. With this commit, we no longer store the "depth" of a name. Instead, we store an offset to the name table where the prefix is found. Since names are serialized in order, the prefix must have already been written. And since the offset is always negative, we actually store its absolute value to save space (the packed U32 format is able to store negative values, but it is inefficient). This change requires persistent format version bump. That has already happened on the `smallrye` branch, so this commit doesn't bump again, but note that this commit can't be backported to Jandex 2.x.
Ladicek
added
the
serialization-format-change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #175