Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More changes to default content type #1615

Merged
merged 1 commit into from
Oct 25, 2023
Merged

More changes to default content type #1615

merged 1 commit into from
Oct 25, 2023

Conversation

phillip-kruger
Copy link
Member

@phillip-kruger phillip-kruger commented Oct 18, 2023 •
edited
Loading

@phillip-kruger phillip-kruger marked this pull request as ready for review October 24, 2023 05:50
@phillip-kruger phillip-kruger force-pushed the more-content-type-fixes branch 2 times, most recently from 8060843 to 682f7a1 Compare October 24, 2023 07:00
@smallrye smallrye deleted a comment from sonarcloud bot Oct 24, 2023
MikeEdgar
MikeEdgar reviewed Oct 24, 2023
View reviewed changes
Copy link
Member

@MikeEdgar MikeEdgar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I commented on the type lookup that I think could be a source of bug reports as-is.

core/src/main/java/io/smallrye/openapi/runtime/scanner/spi/AnnotationScanner.java Outdated Show resolved Hide resolved
@phillip-kruger
More changes to default content type
6c76926 
Signed-off-by: Phillip Kruger <phillip.kruger@gmail.com>
@phillip-kruger
Copy link
Member Author

Thanks @MikeEdgar ! Now getting the type from the method you suggested. Lets merge and release

@phillip-kruger phillip-kruger enabled auto-merge (squash) October 24, 2023 23:06
@sonarcloud
Copy link

sonarcloud bot commented Oct 24, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

74.8% 74.8% Coverage
6.0% 6.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

MikeEdgar
MikeEdgar approved these changes Oct 25, 2023
View reviewed changes
Copy link
Member

@MikeEdgar MikeEdgar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I wonder if we can get away with only calling getResourceParameters once in the JAX-RS scanner.

@phillip-kruger phillip-kruger merged commit 0a672e2 into smallrye:main Oct 25, 2023
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MikeEdgar MikeEdgar MikeEdgar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@phillip-kruger @MikeEdgar