Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow Inheritance for @JsonIgnoreProperties #384

Merged
merged 2 commits into from
Jun 28, 2020
Merged

Allow Inheritance for @JsonIgnoreProperties #384

merged 2 commits into from
Jun 28, 2020

Conversation

tkalmar
Copy link

@tkalmar tkalmar commented Jun 28, 2020

Fixes #374

  • Added Tests (Inheritance worked already if the getters/setters are not overriden but i think this is expected.
  • Enhance IgnoreResolver for Inherited @JsonIgnoreProperties

phillip-kruger
phillip-kruger approved these changes Jun 28, 2020
View reviewed changes
Copy link
Member

@phillip-kruger phillip-kruger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

MikeEdgar
MikeEdgar approved these changes Jun 28, 2020
View reviewed changes
Copy link
Member

@MikeEdgar MikeEdgar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you @tkalmar.

@MikeEdgar MikeEdgar merged commit 405594b into smallrye:master Jun 28, 2020
@MikeEdgar MikeEdgar added this to the 2.0.3 milestone Jul 15, 2020
@phillip-kruger phillip-kruger mentioned this pull request Aug 19, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MikeEdgar MikeEdgar MikeEdgar approved these changes

@phillip-kruger phillip-kruger phillip-kruger approved these changes

@EricWittmann EricWittmann Awaiting requested review from EricWittmann

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.0.3
Development

Successfully merging this pull request may close these issues.

@JsonIgnoreProperties ignored on superclass
3 participants
@tkalmar @phillip-kruger @MikeEdgar