feat: implement registerOnXxx infrastructure for Ruby-to-blocks converter #400
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rter - Add registerOnXxx methods to index.js for declarative handler registration - Add internal storage arrays for registered handlers (_onIfHandlers, etc.) - Update _callConvertersHandler to check registered handlers first - Migrate key converters to use registerOnXxx pattern: * ControlConverter: registerOnIf, registerOnUntil * OperatorsConverter: registerOnAnd, registerOnOr * VariablesConverter: registerOnOpAsgn, registerOnVar, registerOnVasgn * MyBlocksConverter: registerOnVar, registerOnDefs * MotionConverter: registerOnOpAsgn This implements the infrastructure designed in GitHub Issue #399 to modernize onXxx handler patterns into a declarative register pattern, improving code maintainability and consistency with registerCallMethod system. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
- Add null checks for methodToNumArgs and numArgsToNumRubyBlockArgs - Fix 'Cannot read properties of undefined (reading '0')' error - Ensure proper error handling for unknown function calls like 'abc' - Restore proper 'wrong instruction' error messages instead of exceptions This fixes the regression introduced by registerCallMyBlock implementation where undefined function calls would cause exceptions instead of proper error handling. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
takaokouji
changed the base branch from
develop
to
refactor/my-blocks-ruby-to-blocks-converter
…tor/register-on-xxx-handlers
Base automatically changed from
refactor/my-blocks-ruby-to-blocks-converter
to
develop
September 10, 2025 00:41
This commit completes the refactoring of Ruby-to-blocks converter by: - Remove legacy onXxx functions from migrated converters: - control.js: onIf, onUntil - motion.js: onOpAsgn - my-blocks.js: onVar, onDefs - operators.js: onAnd, onOr - variables.js: onOpAsgn, onVar, onVasgn - Remove legacy _converters array infrastructure - Replace with targeted legacy support for unmigrated converters - Maintain backward compatibility for looks, sound, pen, music converters - All tests pass, ensuring functionality is preserved Closes #399 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
github-actions bot
pushed a commit
that referenced
this pull request
Sep 10, 2025
…ster-on-xxx-handlers feat: implement registerOnXxx infrastructure for Ruby-to-blocks converter
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR completes the registerOnXxx infrastructure migration designed in Issue #399, modernizing the Ruby-to-blocks converter by removing legacy onXxx functions and infrastructure while maintaining full backward compatibility.
Implementation Details
Phase 1: Infrastructure Setup ✅
registerOnIf,registerOnUntil,registerOnOpAsgn,registerOnAnd,registerOnOr,registerOnVar,registerOnVasgn,registerOnDefs_onIfHandlers,_onUntilHandlers, etc._callConvertersHandlerto prioritize registered handlersPhase 2: Converter Migration ✅
Migrated converters to use registerOnXxx pattern:
onIf,onUntil→registerOnIf,registerOnUntilonAnd,onOr→registerOnAnd,registerOnOronOpAsgn,onVar,onVasgn→ register equivalentsonVar,onDefs→registerOnVar,registerOnDefsonOpAsgn→registerOnOpAsgnPhase 3: Legacy Cleanup ✅
Benefits Achieved
Test Results ✅
Migration Summary
Files Modified
src/lib/ruby-to-blocks-converter/index.js- Infrastructure and legacy cleanupsrc/lib/ruby-to-blocks-converter/control.js- Removed onIf, onUntilsrc/lib/ruby-to-blocks-converter/motion.js- Removed onOpAsgnsrc/lib/ruby-to-blocks-converter/my-blocks.js- Removed onVar, onDefssrc/lib/ruby-to-blocks-converter/operators.js- Removed onAnd, onOrsrc/lib/ruby-to-blocks-converter/variables.js- Removed onOpAsgn, onVar, onVasgnCloses #399
🤖 Generated with Claude Code