Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix invalid reference to benchmark name #51

Merged
merged 1 commit into from
Jun 15, 2016

Conversation

lhoste-bell
Copy link

No description provided.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 69.05% when pulling 6588176 on lhoste-bell:fix-benchmark-name into e5ebe70 on smarr:master.

@smarr smarr merged commit 6588176 into smarr:master Jun 15, 2016
smarr added a commit that referenced this pull request Jun 15, 2016
Signed-off-by: Stefan Marr <git@stefan-marr.de>
@smarr
Copy link
Owner

smarr commented Jun 15, 2016

Thanks for the fix, I added some tests to avoid regressions. You're still using ReBench? :)

@lhoste-bell
Copy link
Author

Definitely! I like the integration with codespeed too.
However, I'm still looking for a way to produce paper-ready benchmark figures, any hints there? It seems the csv output was deprecated some time ago.

@smarr
Copy link
Owner

smarr commented Jun 17, 2016

I am completely relying on a latex/knitr/tikz setup. I can share that if you are interested.

To get a rough idea, check the are-we-fast-yet report. It consumes the full data files directly.

I used to have matplotlib code in ReBench, but it was never flexible enough, so I removed it and switched completely to R. The latex setup is a little bit involved with all the R dependencies, but, I very much like it. Also because with tikz, the plots are looking very nice and the typesetting is completely uniform with the rest of the document.

And for the CSV stuff, did I really remove that? There should still be a report generator. But, I haven't used it in ages, could well be it is broken.

@lhoste-bell
Copy link
Author

I'm interested for sure. Feel free to share via mail. The CSV is commented out, see here.

@smarr
Copy link
Owner

smarr commented Jun 25, 2016

@lhoste-bell
Copy link
Author

Awesome, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants