Added AQM datamodel #12
Conversation
There was a problem hiding this comment.
Thank you very much for the contribution
Please attend the comments and do not hesitate to contact us for further explanation or to attend to the "Open session" on Mondays.
https://smartdatamodels.org/index.php/summary-open-session/
Thanks
AirQualityMonitoring/schema.json
Outdated
| "type": "string", | ||
| "description": "Property. Model:'https://schema.org/Text'. Major pollutant in the Air Quality Index (AQI)." | ||
| }, | ||
| "": { |
There was a problem hiding this comment.
The name of the property?
AirQualityMonitoring/schema.json
Outdated
| "": { | ||
| "type": "object", | ||
| "description": "Property. ", | ||
| "properties": {} |
There was a problem hiding this comment.
Object's properties should be defined. there are approaches for generic needs. I'd mail you if necessary.
AirQualityMonitoring/schema.json
Outdated
| "co2": { | ||
| "type": "object", | ||
| "description": "Property. Observed value of environmental pollutant Carbon Dioxide (CO2). Value is an object containing attributes representing statistical aggregates derived from past data.", | ||
| "properties": {} |
There was a problem hiding this comment.
See first this https://smartdatamodels.org/co2
Why object?
AirQualityMonitoring/schema.json
Outdated
| "co": { | ||
| "type": "object", | ||
| "description": "Property. Observed value of environmental pollutant Carbon Monoxide (CO). Value is an object containing attributes representing statistical aggregates derived from past data.", | ||
| "properties": {} |
There was a problem hiding this comment.
Why object
See https://smartdatamodels.org/co
AirQualityMonitoring/schema.json
Outdated
| "description": "Property. Observed value of environmental pollutant Carbon Monoxide (CO). Value is an object containing attributes representing statistical aggregates derived from past data.", | ||
| "properties": {} | ||
| }, | ||
| "relativeHumidity": { |
There was a problem hiding this comment.
shouldn't be this a number?
https://smartdatamodels.org/relativeHumidity
AirQualityMonitoring/schema.json
Outdated
| "illuminance": { | ||
| "type": "string", | ||
| "format": "uri", | ||
| "description": "Relationship. Model:'https://schema.org/URL'. Observed instantaneous ambient light intensity." |
There was a problem hiding this comment.
A uri? shouldn't be a number? https://smartdatamodels.org/illuminance
AirQualityMonitoring/schema.json
Outdated
| "no2": { | ||
| "type": "object", | ||
| "description": "Property. Observed value of environmental pollutant Nitrogen Dioxide (NO2). Value is an object containing attributes representing statistical aggregates derived from past data.", | ||
| "properties": {} |
There was a problem hiding this comment.
same as previous
AirQualityMonitoring/ADOPTERS.yaml
Outdated
| @@ -0,0 +1,11 @@ | |||
|
|
|||
There was a problem hiding this comment.
it would be good to mention where the data model is used
AirQualityMonitoring/schema.json
Outdated
| @@ -0,0 +1,166 @@ | |||
| { | |||
There was a problem hiding this comment.
I have reviewed first detail by detail and then globally. My question, how could we ensure a quick and simple interoperability if we do not define what are the objects' properties? There is not a problem with defining them as objects and defining all the possible values (or extending later). But how could you prepare on the other end the reading of the values? In fact, what you are doing is creating a not documented standard (under the need for being very flexible).
Let's comment this
There was a problem hiding this comment.
Hey Alberto, I have made some changes with respect to the schema.json document I believe it should have all the properties required now. If there are modifications required in the payload files please let me know I will modify them as well.
There was a problem hiding this comment.
With regard to the reading of the values we have a different file called the Data Descriptor in which the detailed description of each and every property is mentioned.You can check out Example 1 in this IUDX Vocabulary. This contains the detailed information about each of the properties in the data model.
| @@ -0,0 +1,102 @@ | |||
| { | |||
There was a problem hiding this comment.
This payload is not validated by the schema.json
Hey Alberto, I have taken a look at the incubated data model and made some changes accordingly(Please check modified-schema.json), since some properties remain as [timeseriesaggregation](https://voc.iudx.org.in/TimeSeriesAggregation ) it will contain max,min,avg and instvalue and the pollutants have been put in an array as mentioned in the incubated schema, Please get back to me if there are any more changes |
|
reviewed before publishing |
|
see published one |
No description provided.