Bugfix/177323594 Metadata in JPV2 #4121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I see that you haven't updated any CHANGELOG files. Would it make sense to do so? |
connorwstein
commented
Mar 25, 2021
| @@ -187,7 +187,6 @@ func (r *runner) processUnfinishedRuns() { | |||
| type ( | |||
| memoryTaskRun struct { | |||
| task Task | |||
| taskRun TaskRun | |||
There was a problem hiding this comment.
realizing this isn't necessary since we have task
connorwstein
commented
Mar 25, 2021
| @@ -28,7 +28,7 @@ type ( | |||
| Task interface { | |||
| Type() TaskType | |||
| DotID() string | |||
| Run(ctx context.Context, taskRun TaskRun, inputs []Result) Result | |||
| Run(ctx context.Context, meta JSONSerializable, inputs []Result) Result | |||
There was a problem hiding this comment.
the only thing used from the taskRun was the metadata, just making that explicit
connorwstein
force-pushed
the
bugfix/177323594-metadata-2
branch
from
72604c7
to
68e3146
Compare
connorwstein
requested review from
j16r,
RyanRHall,
samsondav,
se3000 and
spooktheducks
as code owners
connorwstein
commented
Mar 26, 2021
| @@ -312,48 +301,3 @@ func TestAdapterResponse_UnmarshalJSON_Happy(t *testing.T) { | |||
| }) | |||
| } | |||
| } | |||
|
|
|||
| func TestBridgeTask_AddsID(t *testing.T) { | |||
There was a problem hiding this comment.
Follow up ticket addresses the IDs
samsondav
reviewed
Mar 26, 2021
| @@ -193,7 +193,7 @@ func (d Delegate) ServicesForSpec(jobSpec job.Job) (services []job.Service, err | |||
| runResults := make(chan pipeline.RunWithResults, d.config.JobPipelineResultWriteQueueDepth()) | |||
| oracle, err := ocr.NewOracle(ocr.OracleArgs{ | |||
| Database: ocrdb, | |||
| Datasource: dataSource{ | |||
| Datasource: &dataSource{ | |||
There was a problem hiding this comment.
Curious, why change this to a pointer?
There was a problem hiding this comment.
| @@ -173,7 +173,7 @@ func (o *orm) ProcessNextUnfinishedRun(ctx context.Context, fn ProcessRunFunc) ( | |||
| // IDs. | |||
| for i, trr := range trrs { | |||
| for _, tr := range pRun.PipelineTaskRuns { | |||
| if trr.TaskRun.DotID == tr.DotID { | |||
| if trr.Task.DotID() == tr.DotID { | |||
There was a problem hiding this comment.
to kill off TaskRun as it just contains redundant data with Task
samsondav
previously approved these changes
Mar 26, 2021
…tkit/chainlink into bugfix/177323594-metadata-2
j16r
previously approved these changes
Mar 30, 2021
j16r
approved these changes
Mar 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up ticket https://www.pivotaltracker.com/story/show/177510496