Don't wait for I/O on Explorer Start() #4141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
j16r
changed the title
j16r
force-pushed
the
bugfix/6375_dont_wait_for_explorer_io_on_startup
branch
from
f6ef67d
to
c53459c
Compare
j16r
requested review from
connorwstein,
RyanRHall,
samsondav,
se3000 and
spooktheducks
as code owners
This could block Chainlink node startup by up to 45seconds at startup in the worst case.
j16r
force-pushed
the
bugfix/6375_dont_wait_for_explorer_io_on_startup
branch
from
3bc42ad
to
d9c21eb
Compare
connorwstein
approved these changes
Mar 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Explorer Client startup loop tries to connect, and waits for a result from the connect at Startup.
I believe this Start blocks Application startup.
So in the worst case, this could block chainlink by up to 45 seconds before it can process jobs.