Batch fetching in GasUpdater #4243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samsondav
requested review from
connorwstein,
j16r,
RyanRHall,
se3000 and
spooktheducks
as code owners
|
I see that you haven't updated any CHANGELOG files. Would it make sense to do so? |
PiotrTrzpil
previously approved these changes
Apr 19, 2021
| @@ -225,6 +225,9 @@ func (ec *ethConfirmer) CheckForReceipts(ctx context.Context, blockNum int64) er | |||
| if len(attempts) == 0 { | |||
| return nil | |||
| } | |||
| if batchSize == 0 { | |||
| batchSize = len(attempts) | |||
| } | |||
There was a problem hiding this comment.
is this mainly for tests? when do we expect it to be 0 ?
There was a problem hiding this comment.
It's just to protect ourselves in case someone sets it. If we don't special case 0, it will cause the application to enter an infinite loop.
Usually 0 means "disable" so that's what I added here
samsondav
force-pushed
the
bug/ch7190
branch
5 times, most recently
from
ca39452
to
f2ea6e5
Compare
PiotrTrzpil
approved these changes
Apr 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.