Skip to content

Conversation

makramkd
Copy link
Contributor

@makramkd makramkd commented Oct 19, 2023

Description

Ticket: https://smartcontract-it.atlassian.net/browse/VRF-676

  • Update the VRF job spec UI to include vrfOwnerAddress
  • Update the BHS job spec UI to include coordinatorV2PlusAddress, trustedBlockhashStoreAddress and trustedBlockhashStoreBatchSize

Steps to Test

  1. yarn && yarn setup
  2. yarn test

Checklist

If this PR creates changes to the operator-ui itself, rather than tests, pipeline changes, etc. Then please create a changeset so that a new release is created, and the changelog is updated. See: https://github.com/changesets/changesets/blob/main/docs/adding-a-changeset.md#what-is-a-changeset

  • This PR has an accompanying changeset if needed.

@HenryNguyen5
Copy link
Contributor

@makramkd Fixed: dfb6ec5

Same issue as: #17

Could you please update README.md to address fixing this issue? Seems to be an easy one to miss.

jmank88
jmank88 previously approved these changes Oct 19, 2023
@makramkd
Copy link
Contributor Author

Thanks @HenryNguyen5 will update.

@makramkd makramkd marked this pull request as ready for review October 20, 2023 10:52
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a8fbbb3) 81.43% compared to head (3f2d967) 88.31%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #57      +/-   ##
==========================================
+ Coverage   81.43%   88.31%   +6.88%     
==========================================
  Files         148      243      +95     
  Lines        2580     4451    +1871     
  Branches      422      765     +343     
==========================================
+ Hits         2101     3931    +1830     
- Misses        457      499      +42     
+ Partials       22       21       -1     
Files Coverage Δ
src/screens/Job/JobView.tsx 100.00% <ø> (ø)
src/screens/Job/generateJobDefinition.ts 90.66% <ø> (ø)

... and 129 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cl-sonarqube-production
Copy link

SonarQube Quality Gate

Quality Gate failed

Failed condition 26.3% 26.32% Duplicated Lines (%) on New Code (is greater than 3%)

See analysis details on SonarQube

@makramkd makramkd merged commit 06f745d into main Oct 20, 2023
@makramkd makramkd deleted the chore/update-bhs-ui branch October 20, 2023 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants