Skip to content

Add contribution guidelines #178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 27, 2022
Merged

Add contribution guidelines #178

merged 2 commits into from
Sep 27, 2022

Conversation

Mec-iS
Copy link
Collaborator

@Mec-iS Mec-iS commented Sep 27, 2022

Add all docs and files to facilitate contributions

@codecov-commenter
Copy link

codecov-commenter commented Sep 27, 2022

Codecov Report

Merging #178 (426312a) into development (764309e) will increase coverage by 0.04%.
The diff coverage is n/a.

@@               Coverage Diff               @@
##           development     #178      +/-   ##
===============================================
+ Coverage        84.47%   84.51%   +0.04%     
===============================================
  Files               86       86              
  Lines             9940     9940              
===============================================
+ Hits              8397     8401       +4     
+ Misses            1543     1539       -4     
Impacted Files Coverage Δ
src/algorithm/neighbour/cover_tree.rs 84.71% <0.00%> (+0.41%) ⬆️
src/optimization/first_order/lbfgs.rs 94.44% <0.00%> (+1.58%) ⬆️
src/optimization/line_search.rs 92.00% <0.00%> (+2.00%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Collaborator

@morenol morenol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I would add that the coverage (tarpaulin) check is not mandatory (due to limitations in tarpaulin) to merge the PR but is a nice-to-have.

@Mec-iS Mec-iS merged commit 0b619fe into development Sep 27, 2022
@Mec-iS Mec-iS deleted the add-contribution-guides branch September 27, 2022 13:23
morenol pushed a commit that referenced this pull request Nov 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants