Make 1st frame of multi-frame messages always unencrypted #168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This fix is also related to smartdevicelink/sdl_core#2384 and appropriate changes in scripts smartdevicelink/sdl_atf_test_scripts#2146 |
aderiabin
approved these changes
May 29, 2019
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
In case of multi-frame messages 1st frame has to be always unencrypted.
Description:
1st frame incorporates
Total message sizeandNumber of consecutive framesdata.In case if it's encrypted SDL is unable to know how many consecutive frames it has to proceed.
Since SDL tries to do as much as possible sometimes this lack of knowledge does not lead to message drop.
However in case if number of frames > 64 it will very likely lead to message drop.
This PR makes 1st frame to be always unencrypted.