Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix delay for zero expectations in case of callbacks #174

Merged
merged 1 commit into from
Sep 5, 2019
Merged

Fix delay for zero expectations in case of callbacks #174

merged 1 commit into from
Sep 5, 2019

Conversation

dboltovskyi
Copy link
Contributor

Fix: #173

This PR is ready for review.

Summary

Now ATF performs check on zero expectations periodically in CheckStatus() function.
In case if new such expectations is found ATF will apply delay.

Changelog

  • Check on presence of zero expectations moved from runNextCase() to CheckStatus() function.

CLA

@dboltovskyi dboltovskyi force-pushed the fix/delay_for_zero_expectations_in_case_of_callbacks branch from 93459ec to 2124828 Compare August 25, 2019 05:34
@jacobkeeler jacobkeeler merged commit b416694 into develop Sep 5, 2019
@jacobkeeler jacobkeeler deleted the fix/delay_for_zero_expectations_in_case_of_callbacks branch September 5, 2019 20:21
@ShobhitAd ShobhitAd mentioned this pull request Oct 30, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacobkeeler jacobkeeler jacobkeeler approved these changes

@Jack-Byrne Jack-Byrne Awaiting requested review from Jack-Byrne

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dboltovskyi @jacobkeeler