move MenuLayoutsAvailable to WindowCapability #3043
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AByzhynar
reviewed
Sep 20, 2019
| return true; | ||
| } else if (window_id == 0) { | ||
| return true; | ||
| } |
There was a problem hiding this comment.
@iCollin May be this way be better?
if (element.keyExists(strings::window_id)) {
if (helpers::Compare<int, EQ, ONE>(window_id, 0, element[strings::window_id].asInt())) {
return true;
}
}There was a problem hiding this comment.
window_id 0 matches only if the window_id key does not exist on the element.
There was a problem hiding this comment.
@iCollin I see. Thank you. I missed curly braces...
AByzhynar
reviewed
Sep 20, 2019
| for (auto element : *tmp_window_capabilities_arr) { | ||
| if (!element.keyExists(strings::window_id) && element.keyExists(strings::menu_layouts_available)) { | ||
| for (uint32_t i = 0; i < element[strings::menu_layouts_available].length(); ++i) { | ||
| if (layout == static_cast<mobile_apis::MenuLayout::eType>(element[strings::menu_layouts_available][i].asUInt())) { |
There was a problem hiding this comment.
@iCollin Swap comparables please
|
@iCollin Sorry , I have missed the part in the description that PR is NOT ready for review |
1 task
No worries, thanks for being proactive. PR is now ready for review, I have used the style script and made |
rvalue on left side is good practice
Jack-Byrne
approved these changes
Sep 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2925
#2925 was closed with the expectation that this change would be made as part of the fix for #2918
This PR is ready for review.
Risk
This PR makes minor API changes.
Testing Plan
Manually, ATF #2268
Summary
Remove MenuLayoutsAvailable from HMI Capabilities
Add MenuLayoutsAvailable to WindowCapabilities
Changelog
Breaking Changes
CLA