Ensure valid application pointer in RAI::CheckLanguage and FinishSendingResponseToMobile #3815
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacobkeeler
reviewed
Nov 12, 2021
|
Yes good theory, we should also probably check if application has been unregistered before beginning |
jacobkeeler
requested changes
Nov 19, 2021
src/components/application_manager/src/resumption/resume_ctrl_impl.cc
Outdated
Show resolved
Hide resolved
jacobkeeler
approved these changes
Nov 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3813
This PR is ready for review.
Risk
This PR makes no API changes.
Testing Plan
smartdevicelink/sdl_atf_test_scripts#2602
Summary
Prevent derefing nullptr for application in some methods during registration
CLA