Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SDLRPCMessageType enum values are incorrect #36

Closed
joeljfischer opened this issue Jan 20, 2015 · 1 comment
Closed

SDLRPCMessageType enum values are incorrect #36

joeljfischer opened this issue Jan 20, 2015 · 1 comment
Labels
bug A defect in the library

Comments

@joeljfischer
Copy link
Contributor

In the code, the raw values are strings: request, response, and notification. However, in the spec, they are defined as 0, 1, and 2 respectively. PR #33 will cover this issue. A standard NS_ENUM will be created for this case.
@joeljfischer joeljfischer added the bug A defect in the library label Jan 20, 2015
@joeljfischer
Copy link
Contributor Author

This is going to be a backward incompatible change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug A defect in the library
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@joeljfischer