Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Control frame payload initWithData method Crash #715

Closed
BrettyWhite opened this issue Aug 29, 2017 · 0 comments
Closed

Control frame payload initWithData method Crash #715

BrettyWhite opened this issue Aug 29, 2017 · 0 comments
Assignees
@BrettyWhite
Labels
bug A defect in the library
Milestone
4.7.0

Comments

@BrettyWhite
Copy link
Contributor

Bug Report

An incorrect if statement was allowing data that had no contents to proceed to a parsing method. Replacing this with if (data.length > 0) {} correctly checks the data.

Reproduction Steps
  1. Using the example video streaming app configured for SDL_iOS v4.7, starting the video service caused this crash
Expected Behavior
  1. The app does not crash
OS & Version Information
  • iOS Version: 10.3.3
  • SDL iOS Version: 4.7
  • Testing Against: TDK through relay app
@BrettyWhite BrettyWhite added the bug A defect in the library label Aug 29, 2017
@BrettyWhite BrettyWhite self-assigned this Aug 29, 2017
@BrettyWhite BrettyWhite mentioned this issue Aug 29, 2017
Merged
1 task
joeljfischer added a commit that referenced this issue Aug 29, 2017
@joeljfischer
Fix #715 for v5.0.0
e10a5aa
@joeljfischer joeljfischer added this to the 4.7.0 milestone Aug 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BrettyWhite BrettyWhite

Labels
bug A defect in the library
Projects
None yet
Milestone
4.7.0
Development

No branches or pull requests
2 participants
@joeljfischer @BrettyWhite