Support generating the RTP video stream SSRC once at a higher level #1137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@t-yoshii would you please take a look at this PR and make sure it works for your use case? |
NicoleYarroch
approved these changes
Nov 30, 2018
|
@joeljfischer thank you very much for creating fix! |
joeljfischer
deleted the
bugfix/issue_1132_rtp_ssrc_constant_suspension
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1132
This PR is ready for review.
Risk
This PR makes no API changes.
Testing Plan
Unit tests are added
Summary
The RTP packetizer SSRC is now generated by the
SDLStreamingVideoLifecycleManagerand kept constant across suspensions.Changelog
Bug Fixes
CLA