[math] add divide #105
Merged
[math] add divide #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jan N. Klug <jan.n.klug@rub.de>
Signed-off-by: Jan N. Klug <jan.n.klug@rub.de>
|
Two questions: Should we take care of division by 0? Or handle non-terminating decimal expansion like 1/3? Do we need a unit test for both? |
Signed-off-by: Jan N. Klug <jan.n.klug@rub.de>
Signed-off-by: Jan N. Klug <jan.n.klug@rub.de>
|
Good point. BigDecimal throws an ArithmeticException for a division by zero, so I decided to catch that in the AbstractMathTransformationService. This also takes care of other errors that could occur in later additions. Regarding the non terminating expansion: This is a bit difficult, because nobody knows the needed precision. It could be that the transformed value is fed into a Number item and used for other calculations and cutting decimals results in loss of needed precision. |
cweitkamp
approved these changes
May 17, 2021
J-N-K
added a commit
that referenced
this pull request
May 18, 2021
* add divide Signed-off-by: Jan N. Klug <jan.n.klug@rub.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is useful for e.g. to display the remaining time of the dishwasher in minutes instead of seconds. This could also be achieved by multiplying with
0.1666667but having a dedicated transformation for that is more convenient.Signed-off-by: Jan N. Klug jan.n.klug@rub.de