Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[androiddebugbridge] Reorder requests and reuse stored values #115

Merged
merged 2 commits into from
May 29, 2021

Conversation

cweitkamp
Copy link
Contributor

  • Reorder requests and reuse stored values

See #112 (comment)

Signed-off-by: Christoph Weitkamp github@christophweitkamp.de

Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
…t-package Channel

Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
@J-N-K J-N-K requested a review from Trinitus01 May 29, 2021 08:24
@J-N-K
Copy link
Member

J-N-K commented May 29, 2021

LGTM, but I would like to hear what @Trinitus01 thinks about it.

Copy link
Contributor

@Trinitus01 Trinitus01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems you added some more improvements for the package channel. For me it looks fine.

@Trinitus01
Copy link
Contributor

Tested hdmi (not necessary)
Tested wake-lock
Tested current-package

@J-N-K J-N-K merged commit 6e1df68 into smarthomej:3.2.x May 29, 2021
@J-N-K J-N-K added the enhancement New feature or request label May 29, 2021
@J-N-K J-N-K added this to the 3.1.2 milestone May 29, 2021
J-N-K pushed a commit that referenced this pull request May 29, 2021
* Reorder requests and reuse stored wake-lock
* Reorder requests and use stored current-package; improves stop-current-package Channel

Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
@cweitkamp cweitkamp deleted the feature-adb-wakelock branch May 29, 2021 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants