[amazonechocontrol] last spoken text channel #235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added: last spoken text channel Signed-off-by: Tom Blum <trinitus01@googlemail.com>
J-N-K
requested changes
Dec 2, 2021
| @@ -120,82 +121,44 @@ | |||
|
|
|||
| // DeviceTypeIds to human readable description | |||
| // originally found here: https://github.com/Apollon77/ioBroker.alexa2/blob/master/main.js | |||
| public static final Map<String, String> DEVICE_TYPES = Map.<String, String> ofEntries( // | |||
| String json = makeRequestAndReturnString( | ||
| "https://" + amazonSite + "/alexa-privacy/apd/rvh/customer-history-records?startTime=" | ||
| + (startTime != null ? startTime : "") + "&endTime=" + (endTime != null ? endTime : "") | ||
| // + "&recordType=VOICE_HISTORY" |
Comment on lines
789
to
799
|
|
||
| /* | ||
| * DEPRECATED | ||
| * connection.getActivities(10, pushActivity.timestamp).stream().filter(activity -> search.equals(activity.id)) | ||
| * .findFirst() | ||
| * .ifPresent(currentActivity -> currentActivity.getSourceDeviceIds().stream() | ||
| * .map(sourceDeviceId -> findEchoHandlerBySerialNumber(sourceDeviceId.serialNumber)) | ||
| * .filter(Objects::nonNull).forEach(echoHandler -> Objects.requireNonNull(echoHandler) | ||
| * .handlePushActivity(currentActivity))); | ||
| */ | ||
|
|
There was a problem hiding this comment.
remove commented code. If it is needed later, it can be retrieved from the git history.
.../src/main/java/org/smarthomej/binding/amazonechocontrol/internal/handler/AccountHandler.java
Show resolved
Hide resolved
Comment on lines
802
to
803
| Long startTimestamp = timestamp - 30000; | ||
| Long endTimestamp = timestamp + 30000; |
There was a problem hiding this comment.
Suggested change
| Long startTimestamp = timestamp - 30000; | |
| Long endTimestamp = timestamp + 30000; | |
| long startTimestamp = timestamp - 30000; | |
| long endTimestamp = timestamp + 30000; |
.../src/main/java/org/smarthomej/binding/amazonechocontrol/internal/handler/AccountHandler.java
Show resolved
Hide resolved
| if (customerHistoryRecord != null) { | ||
| String recordKey = customerHistoryRecord.recordKey; | ||
| if (recordKey != null && search.equals(recordKey)) { | ||
| EchoHandler echoHandler = findEchoHandlerBySerialNumber(recordKey.split("#")[3]); |
There was a problem hiding this comment.
Is this safe? If recordKey.split returns less than four parts, this will result in an IndexOutOfBoundsException
There was a problem hiding this comment.
It depends on the data of the response, so i will add a check.
Signed-off-by: Tom Blum <trinitus01@googlemail.com>
removed: commented code removed: deprecated method changed: use primitives where possible removed: check for null added: check for length Signed-off-by: Tom Blum <trinitus01@googlemail.com>
Signed-off-by: Tom Blum <trinitus01@googlemail.com>
J-N-K
approved these changes
Dec 2, 2021
J-N-K
added a commit
that referenced
this pull request
Dec 2, 2021
* changed: last voice command via customer history record * added: last spoken text channel Signed-off-by: Tom Blum <trinitus01@googlemail.com> Signed-off-by: Jan N. Klug <jan.n.klug@rub.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changed: last voice command via customer history record
added: last spoken text channel
Signed-off-by: Tom Blum trinitus01@googlemail.com