[viessmann] config and docs improvement #250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
rogrun
commented
Dec 21, 2021
rogrun
commented
- fixes the password display in plain text at the bridge thing config
- correct naming of the client ID
- update of the documentation with a better description
Signed-off-by: Ronny Grun <ronny.grun@t-online.de>
Signed-off-by: Ronny Grun <ronny.grun@t-online.de>
Signed-off-by: Ronny Grun <ronny.grun@t-online.de>
J-N-K
requested changes
Dec 21, 2021
bundles/org.smarthomej.binding.viessmann/src/main/resources/OH-INF/thing/thing-types.xml
Show resolved
Hide resolved
Signed-off-by: Ronny Grun <ronny.grun@t-online.de>
J-N-K
approved these changes
Dec 22, 2021
J-N-K
added a commit
that referenced
this pull request
Dec 22, 2021
* [viessmann] add password context * [viessmann] docs improvement * [viessmann] bridge config improvement Signed-off-by: Ronny Grun <ronny.grun@t-online.de> Signed-off-by: Jan N. Klug <jan.n.klug@rub.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.