[androiddebugbridge] Added mDNS discovery for Fire TV Stick #256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
cweitkamp
commented
Dec 27, 2021
| editProperties.put(Thing.PROPERTY_FIRMWARE_VERSION, adbConnection.getAndroidVersion()); | ||
| editProperties.put(Thing.PROPERTY_VENDOR, adbConnection.getBrand()); | ||
| try { | ||
| editProperties.put(Thing.PROPERTY_MAC_ADDRESS, adbConnection.getMacAddress()); |
There was a problem hiding this comment.
Unfortunately the ro.boot.wifimacaddr property is not available or accessible on all devices but currently it looks like the Mac address is the only unique identifier available in both discovery service implementations.
cweitkamp
commented
Dec 27, 2021
...thomej/binding/androiddebugbridge/internal/discovery/AndroidDebugBridgeDiscoveryService.java
Outdated
Show resolved
Hide resolved
cweitkamp
commented
Dec 27, 2021
...c/main/java/org/smarthomej/binding/androiddebugbridge/internal/AndroidDebugBridgeDevice.java
Show resolved
Hide resolved
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
cweitkamp
changed the title
|
Will this also work on openHAB 3.1? Or at least not cause issues? |
|
Yes, I think but will work in OH 3.1 without any issues. |
J-N-K
reviewed
Dec 27, 2021
.../main/java/org/smarthomej/binding/androiddebugbridge/internal/AndroidDebugBridgeHandler.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
J-N-K
approved these changes
Dec 28, 2021
J-N-K
added a commit
that referenced
this pull request
Dec 28, 2021
* Added mDNS discovery for Fire TV Stick * Use getHardwareAddress() from NetworkInterface * mac address always lower case Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de> Signed-off-by: Jan N. Klug <jan.n.klug@rub.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Christoph Weitkamp github@christophweitkamp.de