Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[repomanager] Initial contribution #3

Merged
merged 3 commits into from
Feb 23, 2021
Merged

Conversation

J-N-K
Copy link
Member

@J-N-K J-N-K commented Feb 21, 2021

Initial contribution of a repository manager

@J-N-K J-N-K force-pushed the connector branch 2 times, most recently from f7363aa to 2765499 Compare February 21, 2021 18:31
Signed-off-by: Jan N. Klug <jan.n.klug@rub.de>
Signed-off-by: Jan N. Klug <jan.n.klug@rub.de>
@J-N-K J-N-K changed the title [connector] Initial contribution [repomanager] Initial contribution Feb 22, 2021
@J-N-K J-N-K added the enhancement New feature or request label Feb 22, 2021
@J-N-K
Copy link
Member Author

J-N-K commented Feb 22, 2021

@splatch I would be very glad if you could have a look. This is a very basic version to get things started. Later versions could use configuration instead of hard-coded URLs and then support also other repositories.

@splatch
Copy link

splatch commented Feb 22, 2021

@J-N-K I had a look this morning and it looks pretty good for first incarnation. Overall repository management with pax-url-mvn is rather tough topic. I remember my failed fights few years ago with unification of version range resolution and authorization injection. Way you did is fairly reasonable.

The only instant suggestion I have right now is usage of OpenHabServlet as a base for repository servlet you made. Just toprotect it with security layer. I think OHC currently might not have a default security handlers in place so it doesn't change much, but leaves space for plugging auth if necessary.

Because pax-url shades maven repository management the actual logic is hidden behind facades - org.ops4j.pax.url.mvn.MavenResolver and org.ops4j.pax.url.mvn.internal.config.MavenConfiguration. If you will have a look there you will find that there is an API to submit online queries. :-) If needed I think we will be able to drive pax-url a bit forward with support for storing modified file (I have commit karma there).

Signed-off-by: Jan N. Klug <jan.n.klug@rub.de>
@J-N-K J-N-K merged commit 86391c2 into smarthomej:main Feb 23, 2021
@J-N-K J-N-K deleted the connector branch February 23, 2021 08:43
@J-N-K J-N-K added this to the 3.1 milestone Mar 13, 2021
@J-N-K J-N-K added newbinding and removed enhancement New feature or request labels Mar 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants