Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[viessmann] read errors from viessmann-api #402

Merged
merged 18 commits into from
Oct 8, 2022
Merged

[viessmann] read errors from viessmann-api #402

merged 18 commits into from
Oct 8, 2022

Conversation

rogrun
Copy link
Contributor

@rogrun rogrun commented Sep 23, 2022

This PR adds support for reading errors from the API

@rogrun
[viessmann] add UpdatingBaseBridgeHandler
1566f89 
Signed-off-by: Ronny Grun <ronny.grun@t-online.de>
@rogrun
[viessmann] add EventsDTO
912460c 
Signed-off-by: Ronny Grun <ronny.grun@t-online.de>
@rogrun
Merge branch '3.2.x-viessmann-read-events' of https://github.com/rogr…
a743395 
…un/addons into 3.2.x-viessmann-read-events
@rogrun
[viessmann] cleanup comments
802998e 
Signed-off-by: Ronny Grun <ronny.grun@t-online.de>
@rogrun
[viessmann] add polling interval for errors
883cee2 
Signed-off-by: Ronny Grun <ronny.grun@t-online.de>
@rogrun
[viessmann] code cleanup
ab6ac87 
Signed-off-by: Ronny Grun <ronny.grun@t-online.de>
@rogrun
[viessmann] add polling interval for errors
cbb83af 
Signed-off-by: Ronny Grun <ronny.grun@t-online.de>
@rogrun
[viessmann] add lastErrorMessage channel
6e3053d 
Signed-off-by: Ronny Grun <ronny.grun@t-online.de>
@rogrun
[viessmann] further work
cfbd34b 
Signed-off-by: Ronny Grun <ronny.grun@t-online.de>
@rogrun
[viessmann] update README.md
ae7b56c 
Signed-off-by: Ronny Grun <ronny.grun@t-online.de>
@rogrun
[viessmann] reorder bridge-type properties
1815e29 
Signed-off-by: Ronny Grun <ronny.grun@t-online.de>
@rogrun
[viessmann] improve logging
762b93c 
Signed-off-by: Ronny Grun <ronny.grun@t-online.de>
@rogrun
[viessmann] fix updating bridge channels
a783d49 
Signed-off-by: Ronny Grun <ronny.grun@t-online.de>
@rogrun
[viessmann] further work
ea4e43f 
Signed-off-by: Ronny Grun <ronny.grun@t-online.de>
@rogrun
[viessmann] update README.de
49d479e 
Signed-off-by: Ronny Grun <ronny.grun@t-online.de>
cweitkamp
cweitkamp reviewed Sep 29, 2022
View reviewed changes
Copy link
Contributor

@cweitkamp cweitkamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new Channels in general are working. I neither had an error in the last couple of days nor know how to provoke one. But think it will work.

I left some minor comments inside.

bundles/org.smarthomej.binding.viessmann/src/main/resources/OH-INF/thing/thing-types.xml Outdated Show resolved Hide resolved
bundles/org.smarthomej.binding.viessmann/src/main/resources/OH-INF/thing/thing-types.xml Outdated Show resolved Hide resolved
.../src/main/java/org/smarthomej/binding/viessmann/internal/handler/ViessmannBridgeHandler.java Show resolved Hide resolved
.../src/main/java/org/smarthomej/binding/viessmann/internal/handler/ViessmannBridgeHandler.java Show resolved Hide resolved
@rogrun
[viessmann] add channelLinked / channelUnlinked
f1c8745 
Signed-off-by: Ronny Grun <ronny.grun@t-online.de>
@rogrun
[viessmann] change category
c5ec108 
Signed-off-by: Ronny Grun <ronny.grun@t-online.de>
@rogrun rogrun marked this pull request as ready for review September 30, 2022 15:20
@rogrun
Copy link
Contributor Author

rogrun commented Oct 2, 2022

@J-N-K @cweitkamp
I've done everything. It's ready for review.

Schwebebahn
Schwebebahn previously approved these changes Oct 3, 2022
View reviewed changes
@cweitkamp
Copy link
Contributor

Thanks for incorporating the changes. In general I am fine with the new feature. But currently I can see additional changes which are addressed by #403 too. What is the reason?

@rogrun
Copy link
Contributor Author

rogrun commented Oct 3, 2022

It was a mistake. I want to merge the two branches into a new one for testing both new features.
I don't know much about GitHub and I don't know how to undo this.

@rogrun rogrun force-pushed the 3.2.x-viessmann-read-events branch from eb6f42a to c5ec108 Compare October 4, 2022 07:54
cweitkamp
cweitkamp reviewed Oct 4, 2022
View reviewed changes
Copy link
Contributor

@cweitkamp cweitkamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. One final question.

.../src/main/java/org/smarthomej/binding/viessmann/internal/handler/ViessmannBridgeHandler.java Show resolved Hide resolved
@rogrun
[viessmann] rename managePolling()
5244e4d 
Signed-off-by: Ronny Grun <ronny.grun@t-online.de>
@J-N-K J-N-K added the enhancement New feature or request label Oct 5, 2022
@J-N-K J-N-K added this to the 3.2.15 milestone Oct 5, 2022
@J-N-K J-N-K merged commit c0bdc19 into smarthomej:3.2.x Oct 8, 2022
@rogrun rogrun deleted the 3.2.x-viessmann-read-events branch October 15, 2022 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cweitkamp cweitkamp cweitkamp approved these changes

@Schwebebahn Schwebebahn Schwebebahn left review comments

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
3.2.15
Development

Successfully merging this pull request may close these issues.
4 participants
@rogrun @cweitkamp @Schwebebahn @J-N-K