-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[androiddebugbridge] add fallback to start package channel #49
Conversation
Does the openURL work on your device? (Because of the -a and -d parameters? Or does it also need a fallback? |
Should i remove all the result empty checks (except the one for the logcat result) in a new pr or will you change it? |
Hi, |
...c/main/java/org/smarthomej/binding/androiddebugbridge/internal/AndroidDebugBridgeDevice.java
Outdated
Show resolved
Hide resolved
...c/main/java/org/smarthomej/binding/androiddebugbridge/internal/AndroidDebugBridgeDevice.java
Show resolved
Hide resolved
...c/main/java/org/smarthomej/binding/androiddebugbridge/internal/AndroidDebugBridgeDevice.java
Outdated
Show resolved
Hide resolved
f2ec55b
to
464bbe6
Compare
tested and works like it should |
I‘m not sure why this happened, but can you please rebase on main? There are some changes which do not belong here. |
There is some irobot binding stuff?!? |
590d8a9
to
972a5d1
Compare
Signed-off-by: Miguel <miguelwork92@gmail.com>
972a5d1
to
a7d45ea
Compare
Signed-off-by: Miguel <miguelwork92@gmail.com>
a7d45ea
to
b15272d
Compare
My fault, it's fixed now. |
...c/main/java/org/smarthomej/binding/androiddebugbridge/internal/AndroidDebugBridgeDevice.java
Show resolved
Hide resolved
...c/main/java/org/smarthomej/binding/androiddebugbridge/internal/AndroidDebugBridgeDevice.java
Outdated
Show resolved
Hide resolved
For isHDMIOn() it seems the first command can fail sometimes but the fallback command is not supported by the device. If this happens it never goes back to the first command. I don't know why it can fail, maybe the result is empty between it switches from 0 to 1 and the cat fetches the result between the two states?!? To get out of the fallback we could remove the fallback from the map if the fallback method runs into an exception. So it will try both (or more fallbacks in the future) again. What do you think about that? How to ensure it tries the first command again if both method fail? |
...c/main/java/org/smarthomej/binding/androiddebugbridge/internal/AndroidDebugBridgeDevice.java
Show resolved
Hide resolved
Signed-off-by: Miguel <miguelwork92@gmail.com>
Signed-off-by: Miguel <miguelwork92@gmail.com>
f91cd3a
to
a7b2eb7
Compare
Add fallback to the start package channel, using monkey command to open applications instead of am on devices which doesn't support the -n parameter (devices under android 8).