Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[irobot] fix MQTT QoS on newer openHAB cores #53

Merged
merged 1 commit into from
Mar 30, 2021
Merged

Conversation

J-N-K
Copy link
Member

@J-N-K J-N-K commented Mar 28, 2021

In older (<3.1) versions of openHAB core the wrong QoS level was sent (0 instead of 1 and vice-versa). After this has been fixed the QoS send in the binding needs to be adapted.

Signed-off-by: Jan N. Klug jan.n.klug@rub.de

Signed-off-by: Jan N. Klug <jan.n.klug@rub.de>
@J-N-K J-N-K added the bug Something isn't working label Mar 28, 2021
@J-N-K J-N-K added this to the 3.1.1 milestone Mar 28, 2021
@J-N-K
Copy link
Member Author

J-N-K commented Mar 28, 2021

@falkena: FYI: This should make it work for 3.0 and 3.1

@J-N-K J-N-K merged commit d11aab3 into smarthomej:main Mar 30, 2021
@J-N-K J-N-K deleted the irobot branch March 30, 2021 17:52
J-N-K added a commit that referenced this pull request Mar 31, 2021
Signed-off-by: Jan N. Klug <jan.n.klug@rub.de>
GiviMAD pushed a commit to GiviMAD/addons that referenced this pull request Mar 31, 2021
Signed-off-by: Jan N. Klug <jan.n.klug@rub.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant