Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tcpudp] Initial contribution #57

Merged
merged 6 commits into from Apr 5, 2021
Merged

[tcpudp] Initial contribution #57

merged 6 commits into from Apr 5, 2021

Conversation

J-N-K
Copy link
Member

@J-N-K J-N-K commented Apr 2, 2021

This is the initial contribution of a openHAB 3 compatible version of the TCP/UDP binding.

@J-N-K
Initial contribution
c875bcd 
Signed-off-by: Jan N. Klug <jan.n.klug@rub.de>
@J-N-K
refactoring
4f08145 
Signed-off-by: Jan N. Klug <jan.n.klug@rub.de>
@J-N-K J-N-K added this to the 3.1.1 milestone Apr 2, 2021
@J-N-K J-N-K added the workinprogress Not yet ready for merge label Apr 2, 2021
@J-N-K
Copy link
Member Author

J-N-K commented Apr 2, 2021

@syntacrsc You might be interested in this one.

@J-N-K
add documentation
7ced0e0 
Signed-off-by: Jan N. Klug <jan.n.klug@rub.de>
@J-N-K J-N-K requested review from Trinitus01 and GiviMAD April 2, 2021 20:44
GiviMAD
GiviMAD reviewed Apr 3, 2021
View reviewed changes
Copy link
Contributor

@GiviMAD GiviMAD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here is what I saw. Amazing work.

bundles/org.smarthomej.binding.tcpudp/README.md Outdated Show resolved Hide resolved
bundles/org.smarthomej.binding.tcpudp/src/main/resources/OH-INF/config/config.xml Outdated Show resolved Hide resolved
....binding.tcpudp/src/main/java/org/smarthomej/binding/tcpudp/internal/TcpUdpThingHandler.java Outdated Show resolved Hide resolved
@J-N-K J-N-K removed the workinprogress Not yet ready for merge label Apr 3, 2021
@J-N-K
address review comments
11c753a 
Signed-off-by: Jan N. Klug <jan.n.klug@rub.de>
@J-N-K
Copy link
Member Author

J-N-K commented Apr 3, 2021

Thanks. I think I addressed all your comments.

GiviMAD
GiviMAD previously approved these changes Apr 3, 2021
View reviewed changes
@J-N-K
fix spotless
90fe4e6 
Signed-off-by: Jan N. Klug <jan.n.klug@rub.de>
Trinitus01
Trinitus01 previously approved these changes Apr 3, 2021
View reviewed changes
GiviMAD
GiviMAD previously approved these changes Apr 3, 2021
View reviewed changes
@J-N-K
consolidate thing types
e139d65 
Signed-off-by: Jan N. Klug <jan.n.klug@rub.de>
@J-N-K J-N-K dismissed stale reviews from GiviMAD and Trinitus01 via e139d65 April 4, 2021 17:14
@J-N-K J-N-K merged commit 7082645 into smarthomej:main Apr 5, 2021
@J-N-K J-N-K deleted the tcpudp branch April 5, 2021 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GiviMAD GiviMAD GiviMAD approved these changes

@Trinitus01 Trinitus01 Trinitus01 left review comments

Assignees
No one assigned
Labels
newbinding
Projects
None yet
Milestone
3.1.1
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@J-N-K @GiviMAD @Trinitus01