[notificationsforfiretv] thing status depending on the last request #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tom Blum <trinitus01@googlemail.com>
J-N-K
requested changes
May 2, 2021
| } catch (Exception e) { | ||
| logger.warn("Unable to connect: {}", e.getMessage()); | ||
| } catch (IOException e) { | ||
| logger.debug("Unable to send notification: {}", e.getMessage()); |
There was a problem hiding this comment.
Suggested change
| logger.debug("Unable to send notification: {}", e.getMessage()); | |
| logger.debug("Unable to send notification: ", e); |
Either log the full stack trace here (if it add useful information) or remove the logging. The change of the thing status is logged anyway, so updating the thing status already logs e.getMessage()
Signed-off-by: Tom Blum <trinitus01@googlemail.com>
J-N-K
approved these changes
May 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added: set thing status depending on the last request
Inspired by your last commit to the http binding.
What do you think about setting the thing status depending on the last request?
It also do a request without a real notification on binding initialisation.
Signed-off-by: Tom Blum trinitus01@googlemail.com