introduce support for log level configuration

[chicco785]

fix #160 and introduce multiple level of logs

• differentia log levels
• add LOGLEVEL env variable
• document env variables

[c0c0n3]

Thanks this is great. Just a couple of things though:

1. I'm assuming you verified manually that the log level gets picked up from the env and then you can see log lines being output at that level or higher but not below. E.g. if env log level = info, then you should not see any debug lines in the logs.
2. Have a look at the other comment in the review---trifling point :-)
3. I added your TODOs about failing geocoding tests to the list of things to look into for #292, so we can deal with that separately, hope that's okay.

[c0c0n3]

Are you saying this because of global state? There's no global state here, you'll get a fresh translator instance each time the notify endpoint gets hit:

• https://github.com/smartsdk/ngsi-timeseries-api/blob/master/src/reporter/reporter.py#L172
• https://github.com/smartsdk/ngsi-timeseries-api/blob/master/src/translators/factory.py#L28
• https://github.com/smartsdk/ngsi-timeseries-api/blob/master/src/translators/crate.py#L1029
• https://github.com/smartsdk/ngsi-timeseries-api/blob/master/src/translators/base_translator.py#L19

Notice the use of a context manager

If that's what you were worrying about I suggest we get rid of this sentence "but it also means that you need to redeploy ql in case of major crate update" since it's going to be confusing.

[chicco785]

then we can remove the comment, still is a query that consume time and 99% with the same result, so if we have somewhere this a static value that is not refreshed every notification, may be a better option.

[chicco785]

I updated the TODO text

[c0c0n3]

yep, excellent point, I opened a separate issue just for that: #302

[chicco785]

1 . I'm assuming you verified manually that the log level gets picked up from the env and then you can see log lines being output at that level or higher but not below. E.g. if env log level = info, then you should not see any debug lines in the logs.

Yes, have verified that, not sure we can develop a test though. It may be quite a pain.

2. Have a look at the other comment in the review---trifling point :-)

Did that

3. I added your TODOs about failing geocoding tests to the list of things to look into for Fix geocoding tests #292, so we can deal with that separately, hope that's okay.

Top!

[c0c0n3]

not sure we can develop a test though. It may be quite a pain.

totally. visual inspection is more than enough for me.

Thanks for the PR, awesome work. I'm going to merge if there's nothing else you'd like to add.

[chicco785]

yes please fill free to merge