-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Async operations #91
Merged
Merged
Async operations #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smikhalevski
force-pushed
the
async-operations
branch
from
October 29, 2023 15:37
6a5cc8f
to
0cea043
Compare
smikhalevski
force-pushed
the
async-operations
branch
from
October 31, 2023 12:17
0cea043
to
608db3e
Compare
smikhalevski
force-pushed
the
async-operations
branch
from
October 31, 2023 15:28
608db3e
to
b0d7225
Compare
smikhalevski
force-pushed
the
async-operations
branch
from
November 20, 2023 19:22
a675a15
to
4ba0d52
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
use
toaddOperation
and addedaddAsyncOperation
, so now async operations can be added to any shape. For example, this allowed to enable support of async shapes inArrayShape.includes
check:Added
checkAsync
,refineAsync
, andalterAsync
;Removed async to sync auto downgrade optimization, so if
parseAsync
is called on a sync shape it would use the async path instead of wrapping a sync path in a promise.New semantics
_applyOperations
now returns a promise if there are async operations.If the shape overrides only
_apply
and doesn't override_applyAsync
then it's only safeto call this method as the last statement in
_apply
. Otherwise, it may return an unexpected promise.If the shape overrides both
_apply
and_applyAsync
then this method would alwayssynchronously return a
Result
inside_apply
.