Skip to content

Remove ProviderConfig as the configuration source for AssumeRoleProvider #3014

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 2, 2023
Merged

Remove ProviderConfig as the configuration source for AssumeRoleProvider #3014

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
34e933b
Remove ProviderConfig as the configuration source for AssumeRoleProvider
rcoh Sep 29, 2023
fed805f
Rename from_secs
rcoh Sep 29, 2023
47fac43
Rename to_builder to into_builder
rcoh Sep 29, 2023
a2848b4
Add to_builder method to SdkConfig
rcoh Sep 29, 2023
22f1b4b
Fix doc linking
rcoh Sep 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions CHANGELOG.next.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -253,3 +253,11 @@ message = "The IMDS Client builder's `build()` method is no longer async."
references = ["smithy-rs#2997"]
meta = { "breaking" = true, "tada" = false, "bug" = false }
author = "jdisanti"

[[aws-sdk-rust]]
message = """The API for [`AssumeRoleProvider`](https://docs.rs/aws-config/latest/aws_config/sts/struct.AssumeRoleProvider.html) has been updated to derive configuration from [`SdkConfig`](https://docs.rs/aws-config/latest/aws_config/struct.SdkConfig.html) instead of `ProviderConfig`.

For more information, see the [Change Log Discussion](https://github.com/awslabs/aws-sdk-rust/discussions/906)"""
meta = { "breaking" = true, "tada" = false, "bug" = false }
references = ["smithy-rs#3014"]
author = "rcoh"
9 changes: 7 additions & 2 deletions aws/rust-runtime/aws-config/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -808,13 +808,18 @@ mod loader {
movable.fetch_add(1, Ordering::Relaxed);
http::Response::new("ok!")
});
let config = from_env().http_connector(conn.clone()).load().await;
let config = from_env()
.fs(Fs::from_slice(&[]))
.env(Env::from_slice(&[]))
.http_connector(conn.clone())
.load()
.await;
config
.credentials_provider()
.unwrap()
.provide_credentials()
.await
.expect_err("no traffic is allowed");
.expect_err("did not expect credentials to be loaded—no traffic is allowed");
let num_requests = num_requests.load(Ordering::Relaxed);
assert!(num_requests > 0, "{}", num_requests);
}
Expand Down
Loading