Skip to content

fix: Eliminate warning when model has only indirect properties #958

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 4, 2025
Merged

fix: Eliminate warning when model has only indirect properties #958

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion ...in/software/amazon/smithy/swift/codegen/integration/serde/struct/StructDecodeGenerator.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ import software.amazon.smithy.model.shapes.MemberShape
import software.amazon.smithy.model.shapes.OperationShape
import software.amazon.smithy.model.shapes.Shape
import software.amazon.smithy.swift.codegen.SwiftWriter
import software.amazon.smithy.swift.codegen.customtraits.SwiftBoxTrait
import software.amazon.smithy.swift.codegen.integration.ProtocolGenerator
import software.amazon.smithy.swift.codegen.integration.serde.member.MemberShapeDecodeGenerator
import software.amazon.smithy.swift.codegen.model.ShapeMetadata
Expand Down Expand Up @@ -46,7 +47,8 @@ open class StructDecodeGenerator(
if (members.isEmpty()) {
writer.write("return \$N()", symbol)
} else {
writer.write("var value = \$N()", symbol)
val decl = "let".takeIf { members.all { it.hasTrait<SwiftBoxTrait>() } } ?: "var"
writer.write("\$L value = \$N()", decl, symbol)
if (isUnwrapped) {
writer.write("let reader = reader.parent ?? reader")
}
Expand Down
Loading