Skip to content

fix: Remove unneeded capture from endpoint params block #978

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 9, 2025
+7 −1
Merged

fix: Remove unneeded capture from endpoint params block #978

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion ...mazon/smithy/swift/codegen/integration/middlewares/OperationEndpointResolverMiddleware.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,13 +80,17 @@ open class OperationEndpointResolverMiddleware(
op: OperationShape,
) {
val params = mutableListOf<String>()
var shouldCaptureConfig = false
ctx.service.getTrait<EndpointRuleSetTrait>()?.ruleSet?.let { node ->
val ruleSet = EndpointRuleSet.fromNode(node)
val staticContextParams = op.getTrait<StaticContextParamsTrait>()?.parameters ?: emptyMap()
val operationContextParams = op.getTrait<OperationContextParamsTrait>()?.parameters ?: emptyMap()
val clientContextParams = ctx.service.getTrait<ClientContextParamsTrait>()?.parameters ?: emptyMap()
val parameters = ruleSet.parameters.toList()
val setToUseForUniqueVarNamesInOperationContextParamCodegen = mutableSetOf<String>()
if (clientContextParams.isNotEmpty() || parameters.any { it.isBuiltIn }) {
shouldCaptureConfig = true
}
parameters
.toList()
.sortedBy { it.name.toString() }
Expand All @@ -113,9 +117,11 @@ open class OperationEndpointResolverMiddleware(
}
}
}
val capture = "[config] ".takeIf { shouldCaptureConfig } ?: ""
writer.openBlock(
"let endpointParamsBlock = { [config] (context: \$N) in",
"let endpointParamsBlock = { \$L(context: \$N) in",
"}",
capture,
SmithyTypes.Context,
) {
writer.write("EndpointParams(\$L)", params.joinToString(", "))
Expand Down
Loading