Skip to content

Replace 'uuid' with '@smithy/uuid' #1706

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 23, 2025
Merged

Replace 'uuid' with '@smithy/uuid' #1706

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions ...codegen/src/main/java/software/amazon/smithy/typescript/codegen/TypeScriptDependency.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,8 +79,9 @@ public enum TypeScriptDependency implements Dependency {

NODE_CONFIG_PROVIDER("dependencies", "@smithy/node-config-provider", false),

UUID_TYPES("dependencies", "@types/uuid", "^9.0.1", false),
UUID("dependencies", "uuid", "^9.0.1", false),
@Deprecated UUID_TYPES("dependencies", "@types/uuid", "^9.0.1", false),
@Deprecated UUID("dependencies", "uuid", "^9.0.1", false),
SMITHY_UUID("dependencies", "@smithy/uuid", false),

// Conditionally added when httpChecksumRequired trait exists
MD5_BROWSER("dependencies", "@smithy/md5-js", false),
Expand Down
9 changes: 3 additions & 6 deletions ...a/software/amazon/smithy/typescript/codegen/integration/HttpBindingProtocolGenerator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -878,8 +878,7 @@ private void writeRequestQueryParam(
String idempotencyComponent = "";
if (isIdempotencyToken && !isRequired) {
writer
.addDependency(TypeScriptDependency.UUID_TYPES)
.addImport("v4", "generateIdempotencyToken", TypeScriptDependency.UUID);
.addImport("v4", "generateIdempotencyToken", TypeScriptDependency.SMITHY_UUID);
idempotencyComponent = " ?? generateIdempotencyToken()";
}
String memberAssertionComponent = (idempotencyComponent.isEmpty() ? "!" : "");
Expand Down Expand Up @@ -1020,8 +1019,7 @@ private void writeNormalHeader(GenerationContext context, HttpBinding binding) {
defaultValue = " || " + s.substring(s.indexOf(": ") + 2, s.length() - 1);
} else if (isIdempotencyToken) {
context.getWriter()
.addDependency(TypeScriptDependency.UUID_TYPES)
.addImport("v4", "generateIdempotencyToken", TypeScriptDependency.UUID);
.addImport("v4", "generateIdempotencyToken", TypeScriptDependency.SMITHY_UUID);
defaultValue = " ?? generateIdempotencyToken()";
}

Expand All @@ -1047,8 +1045,7 @@ private void writeNormalHeader(GenerationContext context, HttpBinding binding) {
constructedHeaderValue += " || " + s.substring(s.indexOf(": ") + 2, s.length() - 1);
} else if (isIdempotencyToken) {
context.getWriter()
.addDependency(TypeScriptDependency.UUID_TYPES)
.addImport("v4", "generateIdempotencyToken", TypeScriptDependency.UUID);
.addImport("v4", "generateIdempotencyToken", TypeScriptDependency.SMITHY_UUID);
constructedHeaderValue += " ?? generateIdempotencyToken()";
} else {
constructedHeaderValue = headerValue;
Expand Down
4 changes: 1 addition & 3 deletions ...in/java/software/amazon/smithy/typescript/codegen/protocols/cbor/CborShapeSerVisitor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,9 +128,7 @@ protected void serializeStructure(ProtocolGenerator.GenerationContext context, S

if (memberShape.hasTrait(IdempotencyTokenTrait.class)) {
writer
.addDependency(TypeScriptDependency.UUID_TYPES)
.addImport("v4", "generateIdempotencyToken", TypeScriptDependency.UUID);

.addImport("v4", "generateIdempotencyToken", TypeScriptDependency.SMITHY_UUID);
writer.write("'$L': [true, _ => _ ?? generateIdempotencyToken()],", memberName);
} else {
if (valueProvider.equals("_ => _")) {
Expand Down
Loading